Re: [PATCH 29/75] cx18: declare MODULE_FIRMWARE

[Ben Hutchings <ben@decadent.org.uk>]

[-- Attachment #1: Type: text/plain, Size: 1870 bytes --]

On Sat, 2009-11-07 at 20:40 -0500, Andy Walls wrote:
> On Sat, 2009-11-07 at 21:51 +0000, Ben Hutchings wrote:
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> >  drivers/media/video/cx18/cx18-av-firmware.c |    1 +
> >  drivers/media/video/cx18/cx18-dvb.c         |    2 ++
> >  drivers/media/video/cx18/cx18-firmware.c    |    3 +++
> >  3 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/media/video/cx18/cx18-av-firmware.c b/drivers/media/video/cx18/cx18-av-firmware.c
> > index b9e8cc5..137445c 100644
> > --- a/drivers/media/video/cx18/cx18-av-firmware.c
> > +++ b/drivers/media/video/cx18/cx18-av-firmware.c
> > @@ -32,6 +32,7 @@
> >  #define CX18_AI1_MUX_INVALID 0x30
> >  
> >  #define FWFILE "v4l-cx23418-dig.fw"
> > +MODULE_FIRMWARE(FWFILE);
> >  
> >  static int cx18_av_verifyfw(struct cx18 *cx, const struct firmware *fw)
> >  {
> > diff --git a/drivers/media/video/cx18/cx18-dvb.c b/drivers/media/video/cx18/cx18-dvb.c
> > index 51a0c33..9f70168 100644
> > --- a/drivers/media/video/cx18/cx18-dvb.c
> > +++ b/drivers/media/video/cx18/cx18-dvb.c
> > @@ -131,6 +131,8 @@ static int yuan_mpc718_mt352_reqfw(struct cx18_stream *stream,
> >  	return ret;
> >  }
> >  
> > +MODULE_FIRMWARE("dvb-cx18-mpc718-mt352.fw");
> > +
> 
> Ben,
> 
> This particular firmware is only needed by one relatively rare TV card.
> Is there any way for MODULE_FIRMWARE advertisements to hint at
> "mandatory" vs. "particular case(s)"?

No, but perhaps there ought to be.  In this case the declaration could
be left out for now.  It is only critical to list all firmware in
drivers that may be needed for booting.

Ben.

-- 
Ben Hutchings
The generation of random numbers is too important to be left to chance.
                                                            - Robert Coveyou

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]