cx25840: GPIO settings wrong for HVR-1850 IR Tx

cx25840: GPIO settings wrong for HVR-1850 IR Tx

[Andy Walls]

Steve,

This code in cx25840-core.c mucks up HVR-1850 IR Tx:

        /* Drive GPIO2 direction and values for HVR1700
         * where an onboard mux selects the output of demodulator
         * vs the 417. Failure to set this results in no DTV.
         * It's safe to set this across all Hauppauge boards
         * currently, regardless of the board type.
         */
        cx25840_write(client, 0x160, 0x1d);
        cx25840_write(client, 0x164, 0x00);

This changes the IR_TX pin to act as GPIO_20 and defaults it to low,
keeping the IR Transmitter LED illuminated.

Setting register 0x160 to 0x1f makes the pin the IR Tx function again.
I don't want to hack it in there though, as I don't know the
implications for other CX2388[578] boards.  I also perceive the cx23885
module GPIOs could be an easy place to introduce regressions if not
careful.


Steve and Hans,

Any ideas?

I know on the list I had bantered around a configure, enable, set, get
etc v4l2_subdev ops for gpio, but I can't remember the details nor the
requirements.

The cx25840 module really needs a way for the cx23885 bridge driver to
set GPIOs cleanly.

Regards,
Andy

Re: cx25840: GPIO settings wrong for HVR-1850 IR Tx

[Andy Walls]

On Fri, 2009-11-27 at 16:11 -0500, Andy Walls wrote:


> Steve and Hans,
> 
> Any ideas?
> 
> I know on the list I had bantered around a configure, enable, set, get
> etc v4l2_subdev ops for gpio, but I can't remember the details nor the
> requirements.
> 
> The cx25840 module really needs a way for the cx23885 bridge driver to
> set GPIOs cleanly.

Nevermind, I've slapped something together at 

	http://linuxtv.org/hg/~awalls/cx23885-ir

for setting up the IO pin multiplexing in the CX23888 A/V core from the
bridge driver.

It does what I need.  Reading GPIOs or setting GPIOs without setting up
the pin config isn't implemented, as I didn't need it.  However, it
should be easier to implement that now. 

Regards,
Andy

Re: cx25840: GPIO settings wrong for HVR-1850 IR Tx

[Steven Toth]

On Sat, Nov 28, 2009 at 1:35 AM, Andy Walls <awalls@radix.net> wrote:
> On Fri, 2009-11-27 at 16:11 -0500, Andy Walls wrote:
>
>
>> Steve and Hans,
>>
>> Any ideas?
>>
>> I know on the list I had bantered around a configure, enable, set, get
>> etc v4l2_subdev ops for gpio, but I can't remember the details nor the
>> requirements.
>>
>> The cx25840 module really needs a way for the cx23885 bridge driver to
>> set GPIOs cleanly.
>
> Nevermind, I've slapped something together at
>
>        http://linuxtv.org/hg/~awalls/cx23885-ir
>
> for setting up the IO pin multiplexing in the CX23888 A/V core from the
> bridge driver.
>
> It does what I need.  Reading GPIOs or setting GPIOs without setting up
> the pin config isn't implemented, as I didn't need it.  However, it
> should be easier to implement that now.

Hi Andy,

I looked over this today and from the 10,000 ft view I think it's
going to work nicely as a replacement for the current HVR1700
workaround and also for the IR pin requirements.

Reviewed-by: Steven Toth <stoth@kernellabs.com>

Regards,

- Steve

-- 
Steven Toth - Kernel Labs
http://www.kernellabs.com