From: Dmitry Sepp <dmitry.sepp@opensynergy.com>
To: <linux-media@vger.kernel.org>, Hans Verkuil <hverkuil@xs4all.nl>
Cc: <virtio-dev@lists.oasis-open.org>, <acourbot@chromium.org>,
<alexlau@chromium.org>, <daniel@ffwll.ch>, <dgreid@chromium.org>,
<dstaessens@chromium.org>, <egranata@google.com>,
<fziglio@redhat.com>, <keiichiw@chromium.org>,
<kraxel@redhat.com>, <marcheu@chromium.org>,
<posciak@chromium.org>, <spice-devel@lists.freedesktop.org>,
<stevensd@chromium.org>, <tfiga@chromium.org>, <uril@redhat.com>,
<samiullah.khawaja@opensynergy.com>,
<kiran.pawar@opensynergy.com>,
Nikolay Martyanov <Nikolay.Martyanov@opensynergy.com>
Subject: Re: [PATCH v2 1/1] video_video: Add the Virtio Video V4L2 driver
Date: Thu, 12 Mar 2020 12:48:49 +0100 [thread overview]
Message-ID: <12620787.dW097sEU6C@os-lin-dmo> (raw)
In-Reply-To: <6f8c37b1-8dc4-e3bb-01ed-4ebedaf90915@xs4all.nl>
Hi Hans,
One more thing:
> GFP_DMA? That's unusual. I'd expect GFP_DMA32. All V4L2 drivers use that.
GFP_DMA32 had no effect for me on arm64. Probably I need to recheck.
Best regards,
Dmitry.
On Donnerstag, 12. März 2020 11:18:26 CET Hans Verkuil wrote:
> On 3/12/20 11:15 AM, Dmitry Sepp wrote:
> > Hi Hans,
> >
> > Thank you for your great detailed review!
> >
> > I won't provide inline answers as your comments totally make sense. There
> > is>
> > only one thing I want to mention:
> >>> + struct video_plane_format plane_format[VIRTIO_VIDEO_MAX_PLANES];
> >>
> >> Why is this virtio specific? Any reason for not using VIDEO_MAX_PLANES?
> >
> > I'd say this is because VIDEO_MAX_PLANES does not exist outside of the
> > Linux OS, so for whatever other system we need a virtio specific
> > definition.
> OK, good reason :-)
>
> It's probably a good thing to add a comment where VIRTIO_VIDEO_MAX_PLANES is
> defined that explains this.
>
> Regards,
>
> Hans
next prev parent reply other threads:[~2020-03-12 11:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 20:27 [PATCH v2 0/1] Virtio Video V4L2 driver Dmitry Sepp
2020-02-18 20:27 ` [PATCH v2 1/1] video_video: Add the " Dmitry Sepp
2020-03-10 10:24 ` Keiichi Watanabe
2020-03-11 0:09 ` Nicolas Dufresne
2020-03-12 11:40 ` Dmitry Sepp
2020-03-13 11:38 ` Keiichi Watanabe
2020-03-11 13:23 ` Hans Verkuil
2020-03-12 10:15 ` Dmitry Sepp
2020-03-12 10:18 ` Hans Verkuil
2020-03-12 11:48 ` Dmitry Sepp [this message]
2020-03-13 10:05 ` Tomasz Figa
2020-03-13 10:27 ` Dmitry Sepp
2020-03-13 11:11 ` Tomasz Figa
2020-03-16 10:36 ` Dmitry Sepp
2020-03-17 6:46 ` Keiichi Watanabe
2020-03-17 6:53 ` Keiichi Watanabe
2020-03-17 9:10 ` Dmitry Sepp
2020-03-17 9:18 ` Keiichi Watanabe
2020-03-11 13:26 ` [PATCH v2 0/1] " Hans Verkuil
2020-03-12 9:03 ` Dmitry Sepp
2020-03-12 9:49 ` Keiichi Watanabe
2020-03-12 9:54 ` Hans Verkuil
2020-03-12 10:11 ` Keiichi Watanabe
2020-03-12 10:29 ` Dmitry Sepp
2020-03-12 10:37 ` Hans Verkuil
2020-03-13 2:29 ` Nicolas Dufresne
2020-03-13 7:54 ` Keiichi Watanabe
2020-03-13 10:09 ` Dmitry Sepp
2020-03-13 11:53 ` Keiichi Watanabe
2020-03-13 10:20 ` Dmitry Sepp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12620787.dW097sEU6C@os-lin-dmo \
--to=dmitry.sepp@opensynergy.com \
--cc=Nikolay.Martyanov@opensynergy.com \
--cc=acourbot@chromium.org \
--cc=alexlau@chromium.org \
--cc=daniel@ffwll.ch \
--cc=dgreid@chromium.org \
--cc=dstaessens@chromium.org \
--cc=egranata@google.com \
--cc=fziglio@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=keiichiw@chromium.org \
--cc=kiran.pawar@opensynergy.com \
--cc=kraxel@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=marcheu@chromium.org \
--cc=posciak@chromium.org \
--cc=samiullah.khawaja@opensynergy.com \
--cc=spice-devel@lists.freedesktop.org \
--cc=stevensd@chromium.org \
--cc=tfiga@chromium.org \
--cc=uril@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox