public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] IR: Fix sysfs attributes declaration
@ 2009-12-29 18:48 Francesco Lavra
  0 siblings, 0 replies; 2+ messages in thread
From: Francesco Lavra @ 2009-12-29 18:48 UTC (permalink / raw)
  To: linux-media

Hi,
This patch fixes the declaration of the sysfs attributes for IR's, which
must be a NULL-terminated array of struct attribute *.
Without this patch, my machine crashes when inserting a DVB card.
I'm using a 2.6.32 kernel.
Regards,
Francesco

Signed-off-by: Francesco Lavra <francescolavra@interfree.it>

--- a/linux/drivers/media/IR/ir-sysfs.c	2009-12-29 19:36:04.000000000 +0100
+++ b/linux/drivers/media/IR/ir-sysfs.c	2009-12-29 19:36:49.000000000 +0100
@@ -127,6 +127,7 @@ static DEVICE_ATTR(current_protocol, S_I
 
 static struct attribute *ir_dev_attrs[] = {
 	&dev_attr_current_protocol.attr,
+	NULL,
 };
 
 /**



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] IR: Fix sysfs attributes declaration
@ 2009-12-31 15:27 Martin Dauskardt
  0 siblings, 0 replies; 2+ messages in thread
From: Martin Dauskardt @ 2009-12-31 15:27 UTC (permalink / raw)
  To: linux-media

I can confirm this problem.

Without this patch (thanks, Francesco!)  I get a kernel stack trace when 
loading the media drivers:
http://home.arcor-online.de/martin.dauskardt/trace1.jpg
http://home.arcor-online.de/martin.dauskardt/trace2.jpg

(An older v4l-dvb hg snapshot from December 5th wotks fine without patch.)

I am also using 2.6.32 and have two DVB and two v4l2 cards in my machine.

Greets,
Martin Dauskardt


 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-12-31 15:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-29 18:48 [PATCH] IR: Fix sysfs attributes declaration Francesco Lavra
  -- strict thread matches above, loose matches on Subject: below --
2009-12-31 15:27 Martin Dauskardt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox