* [PATCH] s2250: Fix write_reg i2c address
@ 2010-01-13 22:15 Pete Eberlein
0 siblings, 0 replies; only message in thread
From: Pete Eberlein @ 2010-01-13 22:15 UTC (permalink / raw)
To: linux-media@vger.kernel.org
The kernel i2c model uses right-aligned 7-bit i2c addresses, but the
2250 firmware uses an 8-bit address in the usb vendor request. A
previous patch by Jean Delvare shifted the i2c addresses 1 bit to the
right, and this patch fixes the write_reg function to shift it back
before sending the vendor request.
Priority: normal
Signed-off-by: Pete Eberlein <pete@sensoray.com>
diff -r 3a4be7d7dabd -r 134a95c0d98b linux/drivers/staging/go7007/s2250-board.c
--- a/linux/drivers/staging/go7007/s2250-board.c Sun Jan 03 17:04:42 2010 +0000
+++ b/linux/drivers/staging/go7007/s2250-board.c Wed Jan 13 14:11:48 2010 -0800
@@ -159,7 +159,7 @@
struct go7007 *go = i2c_get_adapdata(client->adapter);
struct go7007_usb *usb;
int rc;
- int dev_addr = client->addr;
+ int dev_addr = client->addr << 1; /* firmware wants 8-bit address */
u8 *buf;
if (go == NULL)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-01-13 23:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-13 22:15 [PATCH] s2250: Fix write_reg i2c address Pete Eberlein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox