From: Andy Walls <awalls@md.metrocast.net>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Subject: Re: [PATCH 03/15] [RFCv2] Documentation: add v4l2-controls.txt documenting the new controls API.
Date: Sun, 23 May 2010 20:15:08 -0400 [thread overview]
Message-ID: <1274660109.2275.51.camel@localhost> (raw)
In-Reply-To: <201005240117.35431.laurent.pinchart@ideasonboard.com>
On Mon, 2010-05-24 at 01:17 +0200, Laurent Pinchart wrote:
> Hi Hans,
>
> > +Proposals for Extensions
> > +========================
> > +
> > +Some ideas for future extensions to the spec:
> > +
> > +1) Add a V4L2_CTRL_FLAG_HEX to have values shown as hexadecimal instead of
> > +decimal. Useful for e.g. video_mute_yuv.
>
> Shown where ?
In the output of `v4l2-ctl -L` or any other app that builds controls for
the user to see. This is really just a formatting hint for the
application, analogous to "%x" in a printf() format. I think there may
be a larger issue of control formatting hints here.
So now for a digression:
video_mute_yuv is both a very good and bad example:
$ v4l2-ctl -L
...
video_mute_yuv (int) : min=0 max=16777215 step=1 default=32896 value=32896
...
The value is YUV values encoded as 0x00YYUUVV. For the cx18 driver the
default is 32869 or 0x008080 (no luminance and neutral red and blue
chrominance). A hex readout makes the control setting more readable.
But even with improved formatting, this control is a still poor UI
element. Most people can't map a color word, like "green", to a (Y, U,
V) coordinate easily.
I'll assert
a. a menu with a few human-readable color names would be more useful
or
b. the control could really be broken up into three separate sliders,
obviating the need for the HEX formatting hint. Just because the MPEG
encoding engine wants it set as one value, doesn't mean humans must set
it that way.
I suppose since it's in ivtv and cx18, it's mine to fix. :)
Regards,
Andy
> > +2) It is possible to mark in the controls array which controls have been
> > +successfully written and which failed by for example adding a bit to the
> > +control ID. Not sure if it is worth the effort, though.
>
next prev parent reply other threads:[~2010-05-24 0:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-16 13:20 [PATCH 00/15] [RFCv2] [RFC] New control handling framework Hans Verkuil
2010-05-16 13:20 ` [PATCH 01/15] [RFCv2] v4l2: Add new " Hans Verkuil
2010-05-16 13:20 ` [PATCH 02/15] [RFCv2] v4l2-ctrls: reorder 'case' statements to match order in header Hans Verkuil
2010-05-16 13:20 ` [PATCH 03/15] [RFCv2] Documentation: add v4l2-controls.txt documenting the new controls API Hans Verkuil
2010-05-23 23:17 ` Laurent Pinchart
2010-05-24 0:15 ` Andy Walls [this message]
2010-05-24 10:01 ` Hans Verkuil
2010-05-24 9:44 ` Hans Verkuil
2010-05-24 13:43 ` Hans Verkuil
2010-05-16 13:21 ` [PATCH 04/15] [RFCv2] v4l2: hook up the new control framework into the core framework Hans Verkuil
2010-05-16 13:21 ` [PATCH 05/15] [RFCv2] saa7115: convert to the new control framework Hans Verkuil
2010-05-16 13:21 ` [PATCH 06/15] [RFCv2] msp3400: " Hans Verkuil
2010-05-16 13:21 ` [PATCH 07/15] [RFCv2] saa717x: " Hans Verkuil
2010-05-16 13:21 ` [PATCH 08/15] [RFCv2] cx25840/ivtv: replace ugly priv control with s_config Hans Verkuil
2010-05-16 13:21 ` [PATCH 09/15] [RFCv2] cx25840: convert to the new control framework Hans Verkuil
2010-05-16 13:21 ` [PATCH 10/15] [RFCv2] cx2341x: convert to the " Hans Verkuil
2010-05-16 13:21 ` [PATCH 11/15] [RFCv2] wm8775: convert to the new " Hans Verkuil
2010-05-16 13:21 ` [PATCH 12/15] [RFCv2] cs53l32a: convert to " Hans Verkuil
2010-05-16 13:21 ` [PATCH 13/15] [RFCv2] wm8739: convert to the " Hans Verkuil
2010-05-16 13:21 ` [PATCH 14/15] [RFCv2] ivtv: convert gpio subdev to " Hans Verkuil
2010-05-16 13:22 ` [PATCH 15/15] [RFCv2] ivtv: convert to the " Hans Verkuil
2010-05-23 22:03 ` [PATCH 00/15] [RFCv2] [RFC] New control handling framework Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274660109.2275.51.camel@localhost \
--to=awalls@md.metrocast.net \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox