From: Olivier Lorin <olorin75@gmail.com>
To: V4L Mailing List <linux-media@vger.kernel.org>
Cc: Jean-Francois Moine <moinejf@free.fr>
Subject: [PATCH 3/3] Gspca-gl860 driver update
Date: Mon, 31 May 2010 00:27:17 +0200 [thread overview]
Message-ID: <1275258437.18267.27.camel@miniol> (raw)
gspca - gl860: minor functional changes
From: Olivier Lorin <o.lorin@laposte.net>
- Setting changes applied after an end of image marker reception
This is the way MI2020 sensor works.
It seems to be logical to wait for a complete image before
to change a setting.
- 1 ms "msleep" applied to each sensor after USB control data exchange
This was done for two sensors because these exchanges were known to
be too quick depending on laptop model.
It should be fairly logical to apply this delay to each sensor
in order to prevent from having errors with untested hardwares.
Priority: normal
Signed-off-by: Olivier Lorin <o.lorin@laposte.net>
diff -urpN der_gl860i3/gl860.c gl860/gl860.c
--- der_gl860i3/gl860.c 2010-04-29 21:01:15.000000000 +0200
+++ gl860/gl860.c 2010-04-28 23:45:19.000000000 +0200
@@ -63,7 +63,7 @@ static int sd_set_##thename(struct gspca
\
sd->vcur.thename = val;\
if (gspca_dev->streaming)\
- sd->dev_camera_settings(gspca_dev);\
+ sd->waitSet = 1;\
return 0;\
} \
static int sd_get_##thename(struct gspca_dev *gspca_dev, s32 *val)\
@@ -595,10 +595,7 @@ int gl860_RTx(struct gspca_dev *gspca_de
else if (len > 1 && r < len)
PDEBUG(D_ERR, "short ctrl transfer %d/%d", r, len);
- if (_MI2020_ && (val || index))
- msleep(1);
- if (_OV2640_)
- msleep(1);
+ msleep(1);
return r;
}
reply other threads:[~2010-05-30 22:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1275258437.18267.27.camel@miniol \
--to=olorin75@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox