public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Walls <awalls@md.metrocast.net>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Jarod Wilson <jarod@wilsonet.com>, linux-media@vger.kernel.org
Subject: Re: ir-core multi-protocol decode and mceusb
Date: Mon, 31 May 2010 15:38:19 -0400	[thread overview]
Message-ID: <1275334699.2261.45.camel@localhost> (raw)
In-Reply-To: <4C0408A9.4040904@redhat.com>

On Mon, 2010-05-31 at 16:06 -0300, Mauro Carvalho Chehab wrote:
> Hi Andy,
> 
> Em 31-05-2010 09:15, Andy Walls escreveu:
> >> I've now got an ir-lirc-codec bridge passing data over to a completely
> >> unmodified lirc_dev, with the data then making its way out to the
> >> lircd userspace where its even getting properly decoded. I don't have
> >> the transmit side of things in ir-lirc-codec wired up just yet, but
> >> I'd like to submit what I've got (after some cleanup) tomorrow, and
> >> will then incrementally work on transmit. I'm pretty sure wiring up
> >> transmit is going to require some of the bits we'd be using for native
> >> transmit as well, so there may be some discussion required. Will give
> >> a look at setting enabled/disabled decoders tomorrow too, hopefully.
> > 
> > 
> > Since you're looking at Tx, please take a look at the v4l2_subdev
> > interface for ir devices.  See 
> > 
> > linux/include/media/v4l2-subdev.h: struct v4l2_subdev_ir_ops 
> > 
> > I was wondering how this interface could be modified to interface nicely
> > to lirc (or I guess ir-lirc-codec) for transmit functionality.
> 
> > Right now, only the cx23885 driver uses it:
> > 
> > linux/drivers/media/video/cx23885/cx23888-ir.[ch]
> > 
> > I have the skeleton of transmit for the device implemented (it does need
> > some fixing up).
> > 
> > (The CX23888 hardware is nice in that it only deals with raw pulses so
> > one can decode any protocol and transmit any protocols.  The hardware
> > provides hardware counter/timers for measuring incoming pulses and
> > sending outgoing pulses.)
> 
> This interface is bound to V4L needs. As the Remote Controller subsystem
> is meant to support not only V4L or DVB IR's, but also other kinds of remote
> controllers that aren't associated to media devices, it makes no sense on
> binding TX to this interface. 
> 
> The biggest advantage of V4L subdev interface is that a command, like VIDIOC_S_STD
> could be sent to several devices that may need to know what's the current standard,
> in order to configure audio, video, etc. It also provides a nice way to access
> devices on a device-internal bus. In the case of RC, I don't see any similar
> need. So, IMO, the better is to use an in interface similar to RX for TX, e. g.,
> something like:
> 	rc_register_tx()
> 	rc_unregister_tx()
> 	rc_send_code()

Right, I agree.  The v4l2_subdev ir_ops is a detail hidden by the bridge
driver and the bridge driver needs to deal with that.  A registration
process seems to be the proper way to do things.

BTW, maybe

	rc_set_tx_parameters()

is needed as well to set up the parameters for the transmitter.

I haven't looked very hard at rc_register_rx() and related functions so
I will soon.  

Regards,
Andy


  reply	other threads:[~2010-05-31 19:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-28  4:47 ir-core multi-protocol decode and mceusb Jarod Wilson
2010-05-28 19:31 ` Jarod Wilson
2010-05-29 12:39 ` Andy Walls
2010-05-29 16:58   ` Jarod Wilson
2010-05-29 20:01     ` Andy Walls
2010-05-30  2:24       ` Jarod Wilson
2010-05-30 14:02         ` Mauro Carvalho Chehab
2010-05-30 19:57           ` Jarod Wilson
2010-05-31  6:20             ` Jarod Wilson
2010-05-31 12:15               ` Andy Walls
2010-05-31 19:06                 ` Mauro Carvalho Chehab
2010-05-31 19:38                   ` Andy Walls [this message]
2010-05-31 20:58                     ` Mauro Carvalho Chehab
2010-05-31 21:45                       ` Andy Walls
2010-05-31 22:31                         ` Mauro Carvalho Chehab
2010-06-01  5:22                           ` Jarod Wilson
2010-06-03  6:27                             ` Jarod Wilson
2010-06-03 14:31                               ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1275334699.2261.45.camel@localhost \
    --to=awalls@md.metrocast.net \
    --cc=jarod@wilsonet.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox