From: hermann pitton <hermann-pitton@arcor.de>
To: Jean-Michel Grimaldi <jm@via.ecp.fr>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] Terratec Cinergy 250 PCI support
Date: Fri, 25 Jun 2010 01:43:58 +0200 [thread overview]
Message-ID: <1277423038.4742.9.camel@pc07.localdom.local> (raw)
In-Reply-To: <AANLkTim5-Cc-ijE1U7M1DWSF8hcj8svSH30a0YVM4qv9@mail.gmail.com>
Hi, Jean-Michel,
Am Freitag, den 25.06.2010, 00:42 +0200 schrieb Jean-Michel Grimaldi:
> Hi, I have a Terratec Cinergy 250 PCI video card, and a small
> modification in saa7134-cards.c is needed for it to work. I built the
> patch on 2.6.34 version (I sent the modification to the maintainer in
> early 2009 but got no feedback):
>
> -- saa7134-cards.old.c 2010-06-25 00:31:16.000000000 +0200
> +++ saa7134-cards.new.c 2010-06-25 00:30:52.000000000 +0200
> @@ -2833,7 +2833,7 @@
> .tv = 1,
> },{
> .name = name_svideo, /* NOT tested */
> - .vmux = 8,
> + .vmux = 3,
> .amux = LINE1,
> }},
> .radio = {
>
> Thanks for taking it into account in future kernels.
>
hm, don't know who missed it. After Gerd, the main mover on saa7134 was
Hartmut, also /me and some well known others cared.
Official maintainer these days is Mauro.
For latest DVB stuff, you also will meet Mike Krufky.
I'm sorry, but your patch is still wrong.
You do have only a Composite signal. S-Video, with separated chroma and
luma, can only be on vmux 5-9.
NACKED-by: hermann pitton <hermann-pitton@arcor.de>
Cheers,
Hermann
next prev parent reply other threads:[~2010-06-24 23:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 22:42 [PATCH] Terratec Cinergy 250 PCI support Jean-Michel Grimaldi
2010-06-24 23:43 ` hermann pitton [this message]
2010-06-25 21:59 ` hermann pitton
[not found] ` <AANLkTikfcq_MFrz1jnxorZKmHUq9pDrx0aEluXfGfc5a@mail.gmail.com>
2010-07-02 1:16 ` hermann pitton
[not found] ` <AANLkTik-IcqUJz7KTxNvyAeQbPuBg-72a0NSI8-VMT12@mail.gmail.com>
2010-07-08 22:45 ` hermann pitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277423038.4742.9.camel@pc07.localdom.local \
--to=hermann-pitton@arcor.de \
--cc=jm@via.ecp.fr \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox