public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] v4l2-ctrls.c: needs to include slab.h
       [not found] <20100809132314.789e13f3.sfr@canb.auug.org.au>
@ 2010-08-09 17:56 ` Randy Dunlap
  2010-08-11 18:45   ` Tony Vroon
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2010-08-09 17:56 UTC (permalink / raw)
  To: Stephen Rothwell, linux-media, Mauro Carvalho Chehab; +Cc: linux-next, LKML

From: Randy Dunlap <randy.dunlap@oracle.com>

v4l2-ctrls.c needs to include slab.h to prevent build errors:

drivers/media/video/v4l2-ctrls.c:766: error: implicit declaration of function 'kzalloc'
drivers/media/video/v4l2-ctrls.c:786: error: implicit declaration of function 'kfree'
drivers/media/video/v4l2-ctrls.c:1528: error: implicit declaration of function 'kmalloc'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
---
 drivers/media/video/v4l2-ctrls.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20100809.orig/drivers/media/video/v4l2-ctrls.c
+++ linux-next-20100809/drivers/media/video/v4l2-ctrls.c
@@ -19,6 +19,7 @@
  */
 
 #include <linux/ctype.h>
+#include <linux/slab.h>
 #include <media/v4l2-ioctl.h>
 #include <media/v4l2-device.h>
 #include <media/v4l2-ctrls.h>

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] v4l2-ctrls.c: needs to include slab.h
  2010-08-09 17:56 ` [PATCH -next] v4l2-ctrls.c: needs to include slab.h Randy Dunlap
@ 2010-08-11 18:45   ` Tony Vroon
  0 siblings, 0 replies; 2+ messages in thread
From: Tony Vroon @ 2010-08-11 18:45 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Stephen Rothwell, linux-media, Mauro Carvalho Chehab, linux-next,
	LKML, Hans Verkuil

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

On Mon, 2010-08-09 at 10:56 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> v4l2-ctrls.c needs to include slab.h to prevent build errors:

This appears to have been missed. Running mainline git:
Linux amalthea 2.6.35-06998-g3d30701 #1 SMP Wed Aug 11 15:33:16 BST 2010
x86_64 Intel(R) Core(TM)2 Duo CPU T9400 @ 2.53GHz GenuineIntel GNU/Linux

Enabling Video 4 Linux results in the breakage promised by Randy:
> drivers/media/video/v4l2-ctrls.c:766: error: implicit declaration of function 'kzalloc'
> drivers/media/video/v4l2-ctrls.c:786: error: implicit declaration of function 'kfree'
> drivers/media/video/v4l2-ctrls.c:1528: error: implicit declaration of function 'kmalloc'

Please apply.

Regards,
-- 
Tony Vroon
UNIX systems administrator
London Internet Exchange Ltd, Trinity Court, Trinity Street,
Peterborough, PE1 1DA
Registered in England number 3137929
E-Mail: tony@linx.net

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-11 18:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20100809132314.789e13f3.sfr@canb.auug.org.au>
2010-08-09 17:56 ` [PATCH -next] v4l2-ctrls.c: needs to include slab.h Randy Dunlap
2010-08-11 18:45   ` Tony Vroon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox