Re: [PATCH 1/5] rc-code: merge and rename ir-core

[Maxim Levitsky <maximlevitsky@gmail.com>]

On Wed, 2010-09-08 at 23:12 +0200, David Härdeman wrote: 
> On Wed, Sep 08, 2010 at 11:10:40AM -0400, Andy Walls wrote:
> > Tag files and a decent editor are all one needs for full code 
> > navigation.  The kernel makefile already has a tags target to make the 
> > tags file.  
> 
> If you like to use tags, it won't be affected by many or few files so 
> it's not an argument for either approach. 
> 
> > Smaller files make for better logical isolation of functions,limiting 
> > visibilty/scope, 
> 
> Limiting visibility so that you'll have to add explicit declarations to 
> ir-core-priv.h for inter-file function calls and functions that would 
> otherwise be unnecessary (ir_raw_get_allowed_protocols() for example) 
> doesn't sound like an advantage to me.
> 
> > and faster compilation of a file (but maybe at the expense of link 
> > time).  
> 
> *sigh* compile times on my laptop:
> 
> rc-core.o		0.558s
> 
> ir-functions.o		0.321s
> ir-sysfs.o		0.251s
> ir-raw-event.o		0.397s
> rc-map.o		0.265s

I personally don't care much about this.
I use Kscope all the time :-)

However I do care and like very much this patchset because I also would
like to have a per remote input device, and this is first step towards
it.

Best regards,
Maxim Levitsky