From: Joe Perches <joe@perches.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 1/2] dvb: mantis: use '%pM' format to print MAC address
Date: Sat, 11 Sep 2010 09:47:22 -0700 [thread overview]
Message-ID: <1284223642.12180.39.camel@Joe-Laptop> (raw)
In-Reply-To: <a548f44961f97f81054fc877aaef068f936c5ca2.1284213506.git.andy.shevchenko@gmail.com>
On Sat, 2010-09-11 at 16:59 +0300, Andy Shevchenko wrote:
> drivers/media/dvb/mantis/mantis_core.c | 5 +----
> drivers/media/dvb/mantis/mantis_ioc.c | 9 +--------
Hi Andy.
I think these are clearer and more commonly used as:
> dprintk(verbose, MANTIS_ERROR, 0,
> + " MAC Address=[%pM]\n", &mantis->mac_address[0]);
" MAC Address=[%pM]\n", mantis->mac_address);
and
> + dprintk(MANTIS_ERROR, 0, " MAC Address=[%pM]\n", &mac_addr[0]);
dprintk(MANTIS_ERROR, 0, " MAC Address=[%pM]\n", mac_addr);
prev parent reply other threads:[~2010-09-11 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 13:59 [PATCH 1/2] dvb: mantis: use '%pM' format to print MAC address Andy Shevchenko
2010-09-11 13:59 ` [PATCH 2/2] media: cx23885: " Andy Shevchenko
2010-09-11 16:47 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284223642.12180.39.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox