From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:57872 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932269Ab0JOUvo (ORCPT ); Fri, 15 Oct 2010 16:51:44 -0400 Subject: Re: [PATCH 3/5] IR: ene_ir: few bugfixes From: Maxim Levitsky To: Jarod Wilson Cc: lirc-list@lists.sourceforge.net, Jarod Wilson , David =?ISO-8859-1?Q?H=E4rdeman?= , mchehab@infradead.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org In-Reply-To: <20101015200212.GK9658@redhat.com> References: <1287158799-21486-1-git-send-email-maximlevitsky@gmail.com> <1287158799-21486-4-git-send-email-maximlevitsky@gmail.com> <20101015200212.GK9658@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 15 Oct 2010 22:24:55 +0200 Message-ID: <1287174295.1867.1.camel@MAIN> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-ID: Sender: On Fri, 2010-10-15 at 16:02 -0400, Jarod Wilson wrote: > On Fri, Oct 15, 2010 at 06:06:37PM +0200, Maxim Levitsky wrote: > > This is a result of last round of debug with > > Sami R . > > > > Thank you Sami very much! > > > > The biggest bug I fixed is that, > > I was clobbering the CIRCFG register after it is setup > > That wasn't a good idea really > > > > And some small refactoring, etc. > > > > Signed-off-by: Maxim Levitsky > > --- > > drivers/media/IR/ene_ir.c | 43 ++++++++++++++++++++----------------------- > > 1 files changed, 20 insertions(+), 23 deletions(-) > > > > diff --git a/drivers/media/IR/ene_ir.c b/drivers/media/IR/ene_ir.c > > index dc32509..8639621 100644 > > --- a/drivers/media/IR/ene_ir.c > > +++ b/drivers/media/IR/ene_ir.c > ... > > @@ -282,6 +287,7 @@ static void ene_rx_setup(struct ene_device *dev) > > ene_set_reg_mask(dev, ENE_CIRCFG, ENE_CIRCFG_CARR_DEMOD); > > > > /* Enable carrier detection */ > > + ene_write_reg(dev, ENE_CIRCAR_PULS, 0x63); > > Looks sane, though I'd prefer to see symbolic bit names or some such thing > here instead of 0x63. Not something to hold up the patch though. > > Acked-by: Jarod Wilson > 63 isn't a bitfileld, but rather two numbers. 3 is number of carrier pulses to skip, and 6 is number of carrier pulses to average. I have a note about that in header. Best regards, Maxim Levitsky