[GIT PATCHES FOR 2.6.36] Fix msp3400 regression causing mute audio

[GIT PATCHES FOR 2.6.36] Fix msp3400 regression causing mute audio

[Hans Verkuil]

Hi Mauro,

I hope you can fast-track this to Linus! It's a nasty regression. From the log:

"The switch to the new control framework caused a regression where the audio was
no longer unmuted after the carrier scan finished.

The original code attempted to set the volume control to its current value in
order to have the set-volume control code to be called that handles the volume
and muting. However, the framework will not call that code unless the new volume
value is different from the old.

Instead we now call msp_s_ctrl directly.

It is a bit of a hack: we really need a v4l2_ctrl_refresh_ctrl function for this
(or something along those lines).

Thanks to Andy Walls for bisecting this and to Shane Shrybman for reporting it!"

I've tested this with my PVR-350 and the audio is now working properly again.

The solution I've chosen is correct, but a bit too low-level. For 2.6.37 I hope
I can add some support for this to the control framework itself. It's too late
to do that for 2.6.36 though.

Regards,

	Hans

The following changes since commit d65728875a85ac7c8b7d6eb8d51425bacc188980:
  Marek Szyprowski (1):
        V4L/DVB: v4l: radio: si470x: fix unneeded free_irq() call

are available in the git repository at:

  ssh://linuxtv.org/git/hverkuil/v4l-dvb.git msp

Hans Verkuil (1):
      msp3400: fix mute audio regression

 drivers/media/video/msp3400-driver.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

-- 
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco

Re: [GIT PATCHES FOR 2.6.36] Fix msp3400 regression causing mute audio

[Shane Shrybman]

On Sun, 2010-10-17 at 12:43 +0200, Hans Verkuil wrote:
> Hi Mauro,
> 
> I hope you can fast-track this to Linus! It's a nasty regression. From the log:
> 
> "The switch to the new control framework caused a regression where the audio was
> no longer unmuted after the carrier scan finished.
> 
> The original code attempted to set the volume control to its current value in
> order to have the set-volume control code to be called that handles the volume
> and muting. However, the framework will not call that code unless the new volume
> value is different from the old.
> 
> Instead we now call msp_s_ctrl directly.
> 
> It is a bit of a hack: we really need a v4l2_ctrl_refresh_ctrl function for this
> (or something along those lines).
> 
> Thanks to Andy Walls for bisecting this and to Shane Shrybman for reporting it!"
> 
> I've tested this with my PVR-350 and the audio is now working properly again.
> 

I've done a quick test of this patch on 2.6.36-rc8 and confirm it fixes
the no audio issue.

Thanks very much Andy and Hans.

Shane

Re: [GIT PATCHES FOR 2.6.36] Fix msp3400 regression causing mute audio

[Andy Walls]

On Sun, 2010-10-17 at 12:43 +0200, Hans Verkuil wrote:
> Hi Mauro,
> 
> I hope you can fast-track this to Linus! It's a nasty regression. From the log:
> 
> "The switch to the new control framework caused a regression where the audio was
> no longer unmuted after the carrier scan finished.
> 
> The original code attempted to set the volume control to its current value in
> order to have the set-volume control code to be called that handles the volume
> and muting. However, the framework will not call that code unless the new volume
> value is different from the old.

> Thanks to Andy Walls for bisecting this and to Shane Shrybman for reporting it!"

Hans,

Thanks for the prompt fix.

Regards,
Andy