From: Andy Walls <awalls@md.metrocast.net>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] [media] cx231xx: Fix inverted bits for RC on PV Hybrid
Date: Fri, 17 Dec 2010 17:23:29 -0500 [thread overview]
Message-ID: <1292624609.1007.21.camel@morgan.silverblock.net> (raw)
In-Reply-To: <4D0B9C41.8030704@redhat.com>
On Fri, 2010-12-17 at 15:22 -0200, Mauro Carvalho Chehab wrote:
> At Pixelview SBTVD Hybrid, the bits sent by the IR are inverted. Due to that,
> the existing keytables produce wrong codes.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> diff --git a/drivers/media/video/cx231xx/cx231xx-input.c b/drivers/media/video/cx231xx/cx231xx-input.c
> index c236a4e..45e14ca 100644
> --- a/drivers/media/video/cx231xx/cx231xx-input.c
> +++ b/drivers/media/video/cx231xx/cx231xx-input.c
> @@ -27,7 +27,7 @@
> static int get_key_isdbt(struct IR_i2c *ir, u32 *ir_key,
> u32 *ir_raw)
> {
> - u8 cmd;
> + u8 cmd, scancode;
>
> dev_dbg(&ir->rc->input_dev->dev, "%s\n", __func__);
>
> @@ -42,10 +42,21 @@ static int get_key_isdbt(struct IR_i2c *ir, u32 *ir_key,
> if (cmd == 0xff)
> return 0;
>
> - dev_dbg(&ir->rc->input_dev->dev, "scancode = %02x\n", cmd);
> -
> - *ir_key = cmd;
> - *ir_raw = cmd;
> + scancode =
> + ((cmd & 0x01) ? 0x80 : 0) |
> + ((cmd & 0x02) ? 0x40 : 0) |
> + ((cmd & 0x04) ? 0x20 : 0) |
> + ((cmd & 0x08) ? 0x10 : 0) |
> + ((cmd & 0x10) ? 0x08 : 0) |
> + ((cmd & 0x20) ? 0x04 : 0) |
> + ((cmd & 0x40) ? 0x02 : 0) |
> + ((cmd & 0x80) ? 0x01 : 0);
I have to point out this alternate method just for fun:
http://www-graphics.stanford.edu/~seander/bithacks.html#ReverseByteWith32Bits
:D
Regards,
Andy
> + dev_dbg(&ir->rc->input_dev->dev, "cmd %02x, scan = %02x\n",
> + cmd, scancode);
> +
> + *ir_key = scancode;
> + *ir_raw = scancode;
> return 1;
> }
>
prev parent reply other threads:[~2010-12-17 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 17:22 [PATCH] [media] cx231xx: Fix inverted bits for RC on PV Hybrid Mauro Carvalho Chehab
2010-12-17 22:23 ` Andy Walls [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292624609.1007.21.camel@morgan.silverblock.net \
--to=awalls@md.metrocast.net \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox