From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from proofpoint-cluster.metrocast.net ([65.175.128.136]:48083 "EHLO proofpoint-cluster.metrocast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001Ab0L3Mpr (ORCPT ); Thu, 30 Dec 2010 07:45:47 -0500 Subject: Re: [PATCH 3/4] [media] ivtv: Add Adaptec Remote Controller From: Andy Walls To: Mauro Carvalho Chehab Cc: Linux Media Mailing List In-Reply-To: <20101230094509.2ecbf089@gaivota> References: <20101230094509.2ecbf089@gaivota> Content-Type: text/plain; charset="UTF-8" Date: Thu, 30 Dec 2010 07:46:23 -0500 Message-ID: <1293713183.2056.31.camel@morgan.silverblock.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-ID: Sender: Mauro Carvalho Chehab On Thu, 2010-12-30 at 09:45 -0200, Mauro Carvalho Chehab wrote: > As we'll remove lirc_i2c from kernel, move the getkey code to ivtv driver, and > use it for AVC2410. > > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/drivers/media/video/ivtv/ivtv-i2c.c b/drivers/media/video/ivtv/ivtv-i2c.c > index 6817092..8d1b016 100644 > --- a/drivers/media/video/ivtv/ivtv-i2c.c > +++ b/drivers/media/video/ivtv/ivtv-i2c.c > @@ -94,6 +94,7 @@ > #define IVTV_HAUP_INT_IR_RX_I2C_ADDR 0x18 > #define IVTV_Z8F0811_IR_TX_I2C_ADDR 0x70 > #define IVTV_Z8F0811_IR_RX_I2C_ADDR 0x71 [snip] > @@ -219,7 +252,6 @@ struct i2c_client *ivtv_i2c_new_ir_legacy(struct ivtv *itv) > 0x1a, /* Hauppauge IR external - collides with WM8739 */ > 0x18, /* Hauppauge IR internal */ > 0x71, /* Hauppauge IR (PVR150) */ ^^^^ BTW, since a. all ivtv cards that have an IR Rx chip at address 0x71 should be accounted for in ivtv-cards.c b. lirc_i2c is going away c. lirc_zilog should not be probing devices labeled "ir_video" d. ir-kbd-i2c doesn't have defaults for address 0x71 Can you remove the 0x71 case here while you are making changes? Thanks, Andy