From: Lawrence Rust <lawrence@softsystem.co.uk>
To: Andy Walls <awalls@md.metrocast.net>
Cc: Eric Sharkey <eric@lisaneric.org>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
auric <auric@aanet.com.au>, David Gesswein <djg@pdp8online.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, ivtv-users@ivtvdriver.org,
ivtv-devel@ivtvdriver.org
Subject: Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864
Date: Sat, 08 Jan 2011 13:09:10 +0100 [thread overview]
Message-ID: <1294488550.9475.20.camel@gagarin> (raw)
In-Reply-To: <1294094056.10094.41.camel@morgan.silverblock.net>
On Mon, 2011-01-03 at 17:34 -0500, Andy Walls wrote:
> On Sun, 2011-01-02 at 23:00 -0500, Eric Sharkey wrote:
> > On Fri, Dec 31, 2010 at 7:55 PM, Andy Walls <awalls@md.metrocast.net> wrote:
> > > Mauro,
> > >
> > > Please revert at least the wm8775.c portion of commit
> > > fcb9757333df37cf4a7feccef7ef6f5300643864:
> > >
> > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=fcb9757333df37cf4a7feccef7ef6f5300643864
> > >
> > > It completely trashes baseband line-in audio for PVR-150 cards, and
> > > likely does the same for any other ivtv card that has a WM8775 chip.
> >
> > Confirmed. I manually rolled back most of the changes in that commit
> > for wm8775.c, leaving all other files alone, and the audio is now
> > working correctly for me. I haven't yet narrowed it down to exactly
> > which changes in that file cause the problem. I'll try and do that
> > tomorrow if I have time.
Oh dear, you leave the ranch for 5 minutes to a place without email and
all hell breaks loose. Didn't anyone think that New Year is a time for
holidays?
So, for a minor niggle, which is trivially sorted, you pull almost the
whole patch leaving the only bit that causes problems for the Nova-S
(for which the patch was intended). The remnant,
drivers/media/video/cx88/cx88-cards.c line 970, adds wm8775 baseband
audio-in which is horribly distorted without the patch. So I suggest it
too is removed.
Now, if someone can direct me to a full hardware description for the
PVR-150 and datasheets for the components connected to the wm8775 then
I'll endeavour to provide a solution compatible with both. If anyone
can loan me a PVR-150 then so much the better, but it's not essential if
the full docs are available.
-- Lawrence
next prev parent reply other threads:[~2011-01-08 12:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-01 0:55 [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864 Andy Walls
2011-01-03 4:00 ` Eric Sharkey
2011-01-03 22:34 ` Andy Walls
2011-01-04 7:10 ` Hans Verkuil
2011-01-04 13:09 ` Andy Walls
2011-01-08 12:09 ` Lawrence Rust [this message]
2011-01-08 14:22 ` Andy Walls
2011-01-08 18:45 ` Lawrence Rust
2011-01-10 12:39 ` Andy Walls
2011-01-10 12:56 ` Lawrence Rust
2011-01-10 13:24 ` Andy Walls
2011-02-01 15:49 ` Mauro Carvalho Chehab
2011-02-02 23:52 ` Andy Walls
2011-02-03 12:51 ` Lawrence Rust
2011-02-05 17:56 ` Lawrence Rust
2011-02-06 20:46 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294488550.9475.20.camel@gagarin \
--to=lawrence@softsystem.co.uk \
--cc=auric@aanet.com.au \
--cc=awalls@md.metrocast.net \
--cc=djg@pdp8online.com \
--cc=eric@lisaneric.org \
--cc=hverkuil@xs4all.nl \
--cc=ivtv-devel@ivtvdriver.org \
--cc=ivtv-users@ivtvdriver.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox