From: Lawrence Rust <lawrence@softsystem.co.uk>
To: Andy Walls <awalls@md.metrocast.net>
Cc: Eric Sharkey <eric@lisaneric.org>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
auric <auric@aanet.com.au>, David Gesswein <djg@pdp8online.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-media@vger.kernel.org, ivtv-users@ivtvdriver.org,
ivtv-devel@ivtvdriver.org
Subject: Re: [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864
Date: Mon, 10 Jan 2011 13:56:27 +0100 [thread overview]
Message-ID: <1294664187.3340.9.camel@gagarin> (raw)
In-Reply-To: <1294663149.2084.41.camel@morgan.silverblock.net>
On Mon, 2011-01-10 at 07:39 -0500, Andy Walls wrote:
[snip]
> I do see one problem with your patch at the moment:
>
> diff --git a/include/media/wm8775.c b/include/media/wm8775.c
> ...
> + sd->grp_id = WM8775_GID; /* subdev group id */
> ...
> diff --git a/include/media/wm8775.h b/include/media/wm8775.h
> ...
> +/* subdev group ID */
> +#define WM8775_GID (1 << 0)
> +
> ...
>
>
> The wm8775 module probably should not define WM8775_GID and definitely
> should not set sd->grp_id. The sd->grp_id is for the bridge driver's
> use for that v4l2_subdev instance. Some bridge drivers may expect it to
> be 0 unless they set it themselves. The group ID values should be
> defined in the bridge driver, and the sd->grp_id field should be set by
> the bridge driver.
>
> You would want to do that in cx88. See cx23885, ivtv, and cx18 as
> examples of bridge drivers that use the group id field.
You know what, life's too short. I've spent far too long on this at the
expense of far more interesting projects. Every time I put some effort
in someone says just one more thing... I get the message. I'll just
keep the patch for my personal use. For those that are interested I'll
maintain a copy here:
http://www.softsystem.co.uk/download/patches/nova-2.6.37.patch
-- Lawrence
next prev parent reply other threads:[~2011-01-10 12:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-01 0:55 [REGRESSION: wm8775, ivtv] Please revert commit fcb9757333df37cf4a7feccef7ef6f5300643864 Andy Walls
2011-01-03 4:00 ` Eric Sharkey
2011-01-03 22:34 ` Andy Walls
2011-01-04 7:10 ` Hans Verkuil
2011-01-04 13:09 ` Andy Walls
2011-01-08 12:09 ` Lawrence Rust
2011-01-08 14:22 ` Andy Walls
2011-01-08 18:45 ` Lawrence Rust
2011-01-10 12:39 ` Andy Walls
2011-01-10 12:56 ` Lawrence Rust [this message]
2011-01-10 13:24 ` Andy Walls
2011-02-01 15:49 ` Mauro Carvalho Chehab
2011-02-02 23:52 ` Andy Walls
2011-02-03 12:51 ` Lawrence Rust
2011-02-05 17:56 ` Lawrence Rust
2011-02-06 20:46 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294664187.3340.9.camel@gagarin \
--to=lawrence@softsystem.co.uk \
--cc=auric@aanet.com.au \
--cc=awalls@md.metrocast.net \
--cc=djg@pdp8online.com \
--cc=eric@lisaneric.org \
--cc=hverkuil@xs4all.nl \
--cc=ivtv-devel@ivtvdriver.org \
--cc=ivtv-users@ivtvdriver.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox