public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Walls <awalls@md.metrocast.net>
To: Jason Gauthier <jgauthier@lastar.com>
Cc: Jarod Wilson <jarod@wilsonet.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Janne Grunau <j@jannau.net>
Subject: RE: Enable IR on hdpvr
Date: Thu, 13 Jan 2011 00:31:30 -0500	[thread overview]
Message-ID: <1294896690.7921.21.camel@localhost> (raw)
In-Reply-To: <65DE7931C559BF4DBEE42C3F8246249A0B6A9B4A@V-ALBEXCHANGE.ctg.com>

On Thu, 2011-01-13 at 02:16 +0000, Jason Gauthier wrote:
> >> I've got two hdpvrs.  Whenever you're ready to extend your testing,
> >> I'm happy to extend that functional testing.  I didn't get a chance to
> >> look at the FC14 patch yet (busy couple of days), but I will hold off
> >> now, anyway!
> 
> >If all goes well, with Jarrod's change, you should be able to test the
> >hdpvr module with the ir-kbd-i2c module and test IR Rx.
> 
> >Strictly speaking, lirc_zilog needs some rework to use the kernel
> >internal interfaces properly.  It might still work, but don't be
> >surprised if it doesn't.
> 
> >I might get to working on lirc_zilog tonight, but otherwise not until
> >this weekend.
> 
> Sounds good. Will give any feedback I can!  Is Tx completely a no show
> at this point?  

No, it might work.  It's hard to tell, but you best course of action is
to load the hdpvr driver and then load the lirc_zilog module and *do
not* unload it.

The major lirc_zilog problem is *double* registration of the Tx and Rx
interfaces due to an old design in lirc_zilog.c:ir_probe().  Other
subtle problems I noticed were pointer use after kfree() and not
deallocating everything properly on module unload.

How will those affect you?  I don't know...

Regards,
Andy


  reply	other threads:[~2011-01-13  5:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10  0:36 Enable IR on hdpvr Jason Gauthier
     [not found] ` <8AFBEFD7-69E3-4E71-B155-EA773C2FED43@wilsonet.com>
2011-01-10 12:07   ` Andy Walls
2011-01-10 12:12   ` Maybe I'll hack on lirc_zilog.c this coming weekend (Re: Enable IR on hdpvr) Andy Walls
2011-01-10 19:51     ` Jarod Wilson
2011-01-10 12:24   ` Enable IR on hdpvr Janne Grunau
2011-01-10 14:25   ` Jason Gauthier
2011-01-10 19:50     ` Jarod Wilson
2011-01-12  4:40       ` Jarod Wilson
2011-01-12 13:49         ` Jason Gauthier
2011-01-12 23:45           ` Andy Walls
2011-01-13  2:16             ` Jason Gauthier
2011-01-13  5:31               ` Andy Walls [this message]
2011-05-21 18:19               ` Jason Gauthier
2011-05-21 18:46                 ` Jason Gauthier
2011-05-22  2:02                   ` [SOLVED] " Jason Gauthier
2011-05-22  2:13                     ` [SOLVED (not really)] " Jason Gauthier
2011-05-22  3:02                     ` [SOLVED] " Andy Walls
2011-05-22  3:17                       ` Jason Gauthier
2011-01-13  5:23             ` Andy Walls

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294896690.7921.21.camel@localhost \
    --to=awalls@md.metrocast.net \
    --cc=j@jannau.net \
    --cc=jarod@wilsonet.com \
    --cc=jgauthier@lastar.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox