From: Andy Walls <awalls@md.metrocast.net>
To: Jarod Wilson <jarod@wilsonet.com>
Cc: Jean Delvare <khali@linux-fr.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Janne Grunau <j@jannau.net>, Jarod Wilson <jarod@redhat.com>
Subject: Re: [PATCH] hdpvr: enable IR part
Date: Sat, 15 Jan 2011 16:56:48 -0500 [thread overview]
Message-ID: <1295128608.7147.14.camel@localhost> (raw)
In-Reply-To: <C59C652B-B4C2-40B9-A195-7719718ECC9D@wilsonet.com>
On Sat, 2011-01-15 at 01:56 -0500, Jarod Wilson wrote:
> On Jan 15, 2011, at 12:37 AM, Jarod Wilson wrote:
> >>>>>> Registered IR keymap rc-hauppauge-new
> >>>>>> input: i2c IR (HD PVR) as /devices/virtual/rc/rc1/input6
> >>>>>> rc1: i2c IR (HD PVR) as /devices/virtual/rc/rc1
> >>>>>> ir-kbd-i2c: i2c IR (HD PVR) detected at i2c-1/1-0071/ir0 [Hauppage HD PVR I2C]
> Okay, last spam before I head off to bed... :)
>
> I can get ir-kbd-i2c behavior to pretty much match lirc_zilog wrt key repeat,
> by simply setting init_data->polling_interval = 260; in hdpvr-i2c.c, which
> matches up with the delay in lirc_zilog. With the 260 interval:
RC-5 has a repetition interval of about 4096/36kHz = 113.8 ms, IIRC.
Using 260 ms, you are throwing away one repeat from the remote for sure,
maybe two. Maybe that will help you understand what may be going on.
(I've lost the bubble on hdpvr with ir-kbd-i2c.)
Regards,
Andy
> Event: time 1295072449.490542, -------------- Report Sync ------------
> Event: time 1295072453.321206, type 4 (Misc), code 4 (ScanCode), value 15
> Event: time 1295072453.321245, type 1 (Key), code 108 (Down), value 1
> Event: time 1295072453.321252, -------------- Report Sync ------------
> Event: time 1295072453.570512, type 1 (Key), code 108 (Down), value 0
> Event: time 1295072453.570544, -------------- Report Sync ------------
> Event: time 1295072453.575718, type 4 (Misc), code 4 (ScanCode), value 15
> Event: time 1295072453.575744, type 1 (Key), code 108 (Down), value 1
> Event: time 1295072453.575752, -------------- Report Sync ------------
> Event: time 1295072453.816215, type 4 (Misc), code 4 (ScanCode), value 15
> Event: time 1295072454.065515, type 1 (Key), code 108 (Down), value 0
> Event: time 1295072454.065544, -------------- Report Sync ------------
>
> Lowering this a bit, I can get split personality, one press will look like
> what I was originally seeing, another will look like the 260 output.
>
> Adding filtering (return 0 if buf[0] != 0x80) doesn't help any.
>
> The final thing I've noticed tonight is that ir-kbd-i2c calls rc_keydown
> using a value of 0 for its 3rd parameter. From rc-main.c:
>
> * @toggle: the toggle value (protocol dependent, if the protocol doesn't
> * support toggle values, this should be set to zero)
>
> Well, in this case, the protocol *does* use a toggle, so that's probably
> something that could use fixing. Not sure it actually has anything to do with
> the odd repeats I'm seeing. Okay, wasn't too much work to pass along toggle
> values too, but it didn't help any.
>
> I'll sleep on it.
next prev parent reply other threads:[~2011-01-15 21:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 19:54 [PATCH] hdpvr: enable IR part Jarod Wilson
2011-01-14 21:44 ` Andy Walls
2011-01-14 22:08 ` Jarod Wilson
2011-01-15 2:30 ` Jarod Wilson
2011-01-15 4:35 ` Andy Walls
2011-01-15 5:37 ` Jarod Wilson
2011-01-15 5:53 ` Jarod Wilson
2011-01-15 6:56 ` Jarod Wilson
2011-01-15 21:56 ` Andy Walls [this message]
2011-01-15 22:10 ` Jarod Wilson
2011-01-15 14:41 ` Andy Walls
2011-01-15 21:46 ` Andy Walls
-- strict thread matches above, loose matches on Subject: below --
2011-01-15 12:50 Andy Walls
2011-01-15 15:26 ` Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295128608.7147.14.camel@localhost \
--to=awalls@md.metrocast.net \
--cc=j@jannau.net \
--cc=jarod@redhat.com \
--cc=jarod@wilsonet.com \
--cc=khali@linux-fr.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox