From: Andy Walls <awalls@md.metrocast.net>
To: Hugh Dickins <hughd@google.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
David Miller <davem@davemloft.net>,
linux-media@vger.kernel.org,
Devin Heitmueller <dheitmueller@kernellabs.com>
Subject: Re: BUG at mm/mmap.c:2309 when cx18.ko and cx18-alsa.ko loaded
Date: Thu, 10 Mar 2011 19:34:38 -0500 [thread overview]
Message-ID: <1299803678.13462.14.camel@localhost> (raw)
In-Reply-To: <1299445446.2310.157.camel@localhost>
On Sun, 2011-03-06 at 16:04 -0500, Andy Walls wrote:
> On Sun, 2011-03-06 at 10:37 -0800, Hugh Dickins wrote:
> > I do expect the underlying problem to be somewhere down the driver
> > end, given that nobody else has been reporting these issues. I'm
> > hoping that once the cx18 guys have time to try to reproduce it,
> > they'll be better able to track it down.
Hi Hugh,
You were correct. The mistake was in the cx18 driver, in the last thing
that I touched, of course. The code causing the bug isn't anywhere
aside from my private repo.
All,
Sorry for all the noise.
The bug was so idiotic, I fell compelled to show the fix:
diff --git a/drivers/media/video/cx18/cx18-scb.c b/drivers/media/video/cx18/cx18
index fd89ad0..d17ffc8 100644
--- a/drivers/media/video/cx18/cx18-scb.c
+++ b/drivers/media/video/cx18/cx18-scb.c
@@ -28,8 +28,8 @@
int cx18_scb_init_mdl_ent_mgmt(struct cx18 *cx)
{
- cx->scb_mdl_ent_map = kzalloc(BITS_TO_LONGS(SCB_MDL_ENTRIES),
- GFP_KERNEL);
+ cx->scb_mdl_ent_map = kzalloc(BITS_TO_LONGS(SCB_MDL_ENTRIES)
+ * sizeof(long), GFP_KERNEL);
if (cx->scb_mdl_ent_map == NULL) {
CX18_ERR("Fatal: unable to allocate bitmap for managing SCB MDL"
"entries\n");
So now the subsequent call to
bitmap_zero(cx->scb_mdl_ent_map, SCB_MDL_ENTRIES);
doesn't walk off the end of what was allocated.
Apparently BITS_TO_LONGS() is not BITS_TO_LONGS_TO_BYTES().
Regards,
Andy
next prev parent reply other threads:[~2011-03-11 0:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 2:06 BUG at mm/mmap.c:2309 when cx18.ko and cx18-alsa.ko loaded Andy Walls
2011-03-04 15:50 ` Devin Heitmueller
2011-03-04 17:13 ` Andy Walls
2011-03-07 10:32 ` Takashi Iwai
2011-03-05 21:59 ` Andy Walls
2011-03-06 2:03 ` Andy Walls
2011-03-06 18:37 ` Hugh Dickins
2011-03-06 21:04 ` Andy Walls
2011-03-07 2:34 ` Hugh Dickins
2011-03-09 0:37 ` Andy Walls
2011-03-11 0:34 ` Andy Walls [this message]
2011-03-11 0:47 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299803678.13462.14.camel@localhost \
--to=awalls@md.metrocast.net \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dheitmueller@kernellabs.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox