* [PATCH][media] DVB, USB, lmedm04: Fix firmware mem leak in lme_firmware_switch()
@ 2011-04-07 19:46 Jesper Juhl
2011-04-07 19:56 ` Malcolm Priestley
0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2011-04-07 19:46 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Malcolm Priestley, David Härdeman, Jarod Wilson,
linux-kernel, linux-media
Don't leak 'fw' in
drivers/media/dvb/dvb-usb/lmedm04.c::lme_firmware_switch() by failing to
call release_firmware().
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
lmedm04.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
compile tested only
diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c
index cd26e7c..d7cc625 100644
--- a/drivers/media/dvb/dvb-usb/lmedm04.c
+++ b/drivers/media/dvb/dvb-usb/lmedm04.c
@@ -799,7 +799,7 @@ static int lme_firmware_switch(struct usb_device *udev, int cold)
if (cold) {
info("FRM Changing to %s firmware", fw_lme);
lme_coldreset(udev);
- return -ENODEV;
+ ret = -ENODEV;
}
release_firmware(fw);
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][media] DVB, USB, lmedm04: Fix firmware mem leak in lme_firmware_switch()
2011-04-07 19:46 [PATCH][media] DVB, USB, lmedm04: Fix firmware mem leak in lme_firmware_switch() Jesper Juhl
@ 2011-04-07 19:56 ` Malcolm Priestley
2011-04-07 19:59 ` Jesper Juhl
0 siblings, 1 reply; 3+ messages in thread
From: Malcolm Priestley @ 2011-04-07 19:56 UTC (permalink / raw)
To: Jesper Juhl
Cc: Mauro Carvalho Chehab, David Härdeman, Jarod Wilson,
linux-kernel, linux-media
On Thu, 2011-04-07 at 21:46 +0200, Jesper Juhl wrote:
> Don't leak 'fw' in
> drivers/media/dvb/dvb-usb/lmedm04.c::lme_firmware_switch() by failing to
> call release_firmware().
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> lmedm04.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> compile tested only
>
> diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c
> index cd26e7c..d7cc625 100644
> --- a/drivers/media/dvb/dvb-usb/lmedm04.c
> +++ b/drivers/media/dvb/dvb-usb/lmedm04.c
> @@ -799,7 +799,7 @@ static int lme_firmware_switch(struct usb_device *udev, int cold)
> if (cold) {
> info("FRM Changing to %s firmware", fw_lme);
> lme_coldreset(udev);
> - return -ENODEV;
> + ret = -ENODEV;
> }
>
> release_firmware(fw);
This has already been fixed in this commit
http://git.linuxtv.org/media_tree.git?a=commit;h=b328817a2a391d1e879c4252cd3f11a352d3f3bc
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][media] DVB, USB, lmedm04: Fix firmware mem leak in lme_firmware_switch()
2011-04-07 19:56 ` Malcolm Priestley
@ 2011-04-07 19:59 ` Jesper Juhl
0 siblings, 0 replies; 3+ messages in thread
From: Jesper Juhl @ 2011-04-07 19:59 UTC (permalink / raw)
To: Malcolm Priestley
Cc: Mauro Carvalho Chehab, David Härdeman, Jarod Wilson,
linux-kernel, linux-media
On Thu, 7 Apr 2011, Malcolm Priestley wrote:
> On Thu, 2011-04-07 at 21:46 +0200, Jesper Juhl wrote:
> > Don't leak 'fw' in
> > drivers/media/dvb/dvb-usb/lmedm04.c::lme_firmware_switch() by failing to
> > call release_firmware().
> >
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> > ---
> > lmedm04.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > compile tested only
> >
> > diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c
> > index cd26e7c..d7cc625 100644
> > --- a/drivers/media/dvb/dvb-usb/lmedm04.c
> > +++ b/drivers/media/dvb/dvb-usb/lmedm04.c
> > @@ -799,7 +799,7 @@ static int lme_firmware_switch(struct usb_device *udev, int cold)
> > if (cold) {
> > info("FRM Changing to %s firmware", fw_lme);
> > lme_coldreset(udev);
> > - return -ENODEV;
> > + ret = -ENODEV;
> > }
> >
> > release_firmware(fw);
>
> This has already been fixed in this commit
>
> http://git.linuxtv.org/media_tree.git?a=commit;h=b328817a2a391d1e879c4252cd3f11a352d3f3bc
>
I see. Thanks. I was not aware of that.
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-07 19:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-07 19:46 [PATCH][media] DVB, USB, lmedm04: Fix firmware mem leak in lme_firmware_switch() Jesper Juhl
2011-04-07 19:56 ` Malcolm Priestley
2011-04-07 19:59 ` Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox