From: Andy Walls <awalls@md.metrocast.net>
To: Colin Minihan <colin.minihan@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: Build Failure
Date: Sat, 30 Apr 2011 12:10:14 -0400 [thread overview]
Message-ID: <1304179815.2434.10.camel@localhost> (raw)
In-Reply-To: <BANLkTim9vtBAE1dbOXAwW2Crh7aiMucD3w@mail.gmail.com>
On Sat, 2011-04-30 at 10:31 -0400, Colin Minihan wrote:
> On Ubuntu 10.04 attempting to run
>
> git clone git://linuxtv.org/media_build.git
> cd media_build
> ./check_needs.pl
> make -C linux/ download
> make -C linux/ untar
> make stagingconfig
> make
>
> results in the following failure
> ...
> CC [M] /home/colm/media_build/v4l/lirc_zilog.o
> /home/colm/media_build/v4l/lirc_zilog.c: In function 'destroy_rx_kthread':
> /home/colm/media_build/v4l/lirc_zilog.c:238: error: implicit
> declaration of function 'IS_ERR_OR_NULL'
Well, IS_ERR_OR_NULL() went into the kernel in December 2009:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=603c4ba96be998a8dd7a6f9b23681c49acdf4b64
so it should be in kernel version 2.6.33 and later.
If you don't want to generate a patch for the media_build backward
compatability build system, you can probably just patch your kernel
header file or trivially hack the function it into
drivers/staging/lirc/lirc_zilog.c
to get past your current build error. But I suspect you'll run into
more errors. When I make changes to a module (like lirc_zilog.c), I
tend to use the latest kernel interfaces at the time of the changes.
If you don't need lirc_zilog.ko built, then configure the build system
to not build the module.
Regards,
Andy
> make[3]: *** [/home/colm/media_build/v4l/lirc_zilog.o] Error 1
> make[2]: *** [_module_/home/colm/media_build/v4l] Error 2
> make[2]: Leaving directory `/usr/src/linux-headers-2.6.32-31-generic'
> make[1]: *** [default] Error 2
> make[1]: Leaving directory `/home/colm/media_build/v4l'
> make: *** [all] Error 2
> --
next prev parent reply other threads:[~2011-04-30 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTikBm0gmNd8oQ6CN+cAEbYhWEGvWPA@mail.gmail.com>
2011-04-30 14:31 ` Build Failure Colin Minihan
2011-04-30 16:10 ` Andy Walls [this message]
2011-05-01 1:28 ` Mauro Carvalho Chehab
2011-05-01 11:50 ` Vincent McIntyre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304179815.2434.10.camel@localhost \
--to=awalls@md.metrocast.net \
--cc=colin.minihan@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox