From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
rtc-linux@googlegroups.com,
Linus Walleij <linus.walleij@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
David Brown <david.brown@linaro.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Krzysztof Kozlowski <k.kozlowski.k@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
devel@driverdev.osuosl.org, linux-samsung-soc@vger.kernel.org,
Vinod Koul <vinod.koul@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Andy Gross <andy.gross@linaro.org>,
linux-media@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-soc@vger.kernel.org,
Alessandro Zummo <a.zummo@towertech.it>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
netdev@vger.kernel.org, dmaengine@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [rtc-linux] Re: [RFC 09/15] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM
Date: Thu, 03 Mar 2016 14:05:33 +0100 [thread overview]
Message-ID: <13054519.5feSCc5dgv@wuerfel> (raw)
In-Reply-To: <CAJKOXPe50ira_Qqy7qJ5H_PHa8B_xOinCK6JkncXFYn_eaQFfg@mail.gmail.com>
On Thursday 03 March 2016 21:40:23 Krzysztof Kozlowski wrote:
> >> select MFD_SYSCON
> >> diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/platform/exynos4-is/Kconfig
> >> index 57d42c6172c5..c4317b99d257 100644
> >> --- a/drivers/media/platform/exynos4-is/Kconfig
> >> +++ b/drivers/media/platform/exynos4-is/Kconfig
> >> @@ -17,6 +17,7 @@ config VIDEO_S5P_FIMC
> >> tristate "S5P/EXYNOS4 FIMC/CAMIF camera interface driver"
> >> depends on I2C
> >> depends on HAS_DMA
> >> + depends on HAS_IOMEM # For MFD_SYSCON
> >> select VIDEOBUF2_DMA_CONTIG
> >> select V4L2_MEM2MEM_DEV
> >
> > This is guarded by HAS_DMA, which implies HAS_IOMEM afaik.
>
> Looking at Kconfigs - no, it is not implied (or am I missing
> something)... and sometimes dependency on HAS_IOMEM is next to
> HAS_DMA.
>
>
Ah, you are right: UML has no DMA and no IOMEM, but s390 can
have IOMEM (if PCI is enabled) and always sets HAS_DMA.
In practice, I think the HAS_DMA symbol is not as well-defined
as it should be, it basically refers to the presence of the dma-mapping.h
API, and that only really makes sense when you also have IOMEM,
so there might be an implied dependency between the two, but it's
not enforced or actually true.
Arnd
next prev parent reply other threads:[~2016-03-03 13:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 8:03 [RFC 00/15] tree-wide: mfd: syscon: Fix unmet ioremap dependency Krzysztof Kozlowski
2016-03-03 8:03 ` [RFC 01/15] clocksource: atmel: Add missing MFD_SYSCON dependency on HAS_IOMEM Krzysztof Kozlowski
2016-03-03 10:52 ` Arnd Bergmann
2016-03-03 8:03 ` [RFC 02/15] dmaengine: nxp: " Krzysztof Kozlowski
2016-03-03 10:52 ` Arnd Bergmann
2016-03-03 8:03 ` [RFC 03/15] hwspinlock: qcom: " Krzysztof Kozlowski
2016-03-03 10:53 ` Arnd Bergmann
2016-03-03 8:03 ` [RFC 04/15] irqchip: st: " Krzysztof Kozlowski
2016-03-03 10:53 ` Arnd Bergmann
2016-03-03 12:00 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03 12:28 ` Arnd Bergmann
2016-03-03 12:33 ` Krzysztof Kozłowski
2016-03-03 8:03 ` [RFC 05/15] phy: hi6220: " Krzysztof Kozlowski
2016-03-03 10:54 ` Arnd Bergmann
2016-03-03 8:03 ` [RFC 06/15] pinctrl: rockchip: " Krzysztof Kozlowski
2016-03-03 12:44 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03 8:03 ` [RFC 07/15] pinctrl: mvebu: " Krzysztof Kozlowski
2016-03-03 12:43 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03 8:03 ` [RFC 08/15] rtc: at91sam9: " Krzysztof Kozlowski
2016-03-03 10:55 ` Arnd Bergmann
2016-03-03 12:27 ` Geert Uytterhoeven
2016-03-03 12:58 ` Arnd Bergmann
2016-03-03 8:03 ` [RFC 09/15] media: platform: " Krzysztof Kozlowski
2016-03-03 10:57 ` Arnd Bergmann
2016-03-03 12:28 ` Geert Uytterhoeven
2016-03-03 12:40 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03 13:05 ` Arnd Bergmann [this message]
2016-03-03 8:03 ` [RFC 10/15] net: ethernet: " Krzysztof Kozlowski
2016-03-03 10:59 ` Arnd Bergmann
2016-03-03 8:03 ` [RFC 11/15] power: reset: keystone: " Krzysztof Kozlowski
2016-03-03 11:00 ` Arnd Bergmann
2016-03-03 12:33 ` Sebastian Reichel
2016-03-03 12:35 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03 8:03 ` [RFC 12/15] soc: qcom: " Krzysztof Kozlowski
2016-03-03 12:43 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03 8:03 ` [RFC 13/15] staging: media: omap4iss: " Krzysztof Kozlowski
2016-03-03 12:42 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-03 8:03 ` [RFC 14/15] usb: xhci: mtk: " Krzysztof Kozlowski
2016-03-03 11:01 ` Arnd Bergmann
2016-03-03 8:03 ` [RFC 15/15] mfd: syscon: Fix build of missing ioremap on UM Krzysztof Kozlowski
2016-03-03 10:50 ` Arnd Bergmann
2016-03-03 12:24 ` [rtc-linux] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13054519.5feSCc5dgv@wuerfel \
--to=arnd@arndb.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=andy.gross@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=david.brown@linaro.org \
--cc=dbaryshkov@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmaengine@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason@lakedaemon.net \
--cc=k.kozlowski.k@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=kishon@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=rtc-linux@googlegroups.com \
--cc=sre@kernel.org \
--cc=tglx@linutronix.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox