From: Luciano Coelho <coelho@ti.com>
To: matti.j.aaltonen@nokia.com
Cc: johannes@sipsolutions.net, linux-kernel@vger.kernel.org,
sameo@linux.intel.com, mchehab@infradead.org,
linux-media@vger.kernel.org
Subject: Kconfig unmet dependency with RADIO_WL1273
Date: Mon, 29 Aug 2011 20:02:38 +0300 [thread overview]
Message-ID: <1314637358.2296.395.camel@cumari> (raw)
Hi Matti,
Johannes has just reported a problem in the Kconfig of radio-wl1273. It
seems to select MFD_CORE, but if the platform doesn't support MFD, then
MFD_SUPPORT won't be selected and this kind of warning will come out:
warning: (OLPC_XO1_PM && OLPC_XO1_SCI && I2C_ISCH && GPIO_SCH && GPIO_RDC321X && RADIO_WL1273)
selects MFD_CORE which has unmet direct dependencies (MFD_SUPPORT)
I guess it must depend on MFD_SUPPORT, right? If that's the correct
solution, the following patch should fix the problem:
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 52798a1..e87f544 100644
--- a/drivers/media/radio/Kconfig
+++ b/drivers/media/radio/Kconfig
@@ -425,7 +425,7 @@ config RADIO_TIMBERDALE
config RADIO_WL1273
tristate "Texas Instruments WL1273 I2C FM Radio"
- depends on I2C && VIDEO_V4L2
+ depends on I2C && VIDEO_V4L2 && MFD_SUPPORT
select MFD_CORE
select MFD_WL1273_CORE
select FW_LOADER
The same problem is happening with other drivers too, so maybe there is
a better solution to fix all problems at once. ;)
Reported-by: Johannes Berg <johannes@sipsolutions.net>
--
Cheers,
Luca.
next reply other threads:[~2011-08-29 17:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 17:02 Luciano Coelho [this message]
2011-08-29 17:27 ` Kconfig unmet dependency with RADIO_WL1273 Randy Dunlap
2011-08-29 18:41 ` [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE Luciano Coelho
2011-08-29 18:54 ` Grant Likely
2011-08-31 16:18 ` Jean Delvare
2011-08-31 16:49 ` Arnd Bergmann
2011-09-02 11:54 ` Luciano Coelho
2011-09-02 12:37 ` Jean Delvare
2011-09-02 14:43 ` [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES Arnd Bergmann
2011-09-05 12:41 ` Jean Delvare
2011-09-05 14:19 ` Arnd Bergmann
2011-09-05 14:27 ` Jean Delvare
2011-09-18 15:11 ` Randy Dunlap
2011-09-18 15:28 ` Greg KH
2011-09-18 18:45 ` Randy Dunlap
2011-09-19 8:47 ` Arnd Bergmann
2011-09-19 13:07 ` Greg KH
2011-09-19 15:14 ` Arnd Bergmann
2011-09-02 14:43 ` [PATCH 2/2] mfd: remove CONFIG_MFD_SUPPORT Arnd Bergmann
2011-09-05 13:09 ` Jean Delvare
2011-09-15 15:46 ` Samuel Ortiz
2011-09-02 15:49 ` [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE Arnd Bergmann
2011-09-15 17:16 ` Grant Likely
2011-09-19 15:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314637358.2296.395.camel@cumari \
--to=coelho@ti.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matti.j.aaltonen@nokia.com \
--cc=mchehab@infradead.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox