From: Luciano Coelho <coelho@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
matti.j.aaltonen@nokia.com, johannes@sipsolutions.net,
linux-kernel@vger.kernel.org, sameo@linux.intel.com,
mchehab@infradead.org, linux-media@vger.kernel.org,
linux-omap@vger.kernel.org, Jean Delvare <khali@linux-fr.org>,
Tony Lindgren <tony@atomide.com>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE
Date: Fri, 02 Sep 2011 14:54:55 +0300 [thread overview]
Message-ID: <1314964495.2296.632.camel@cumari> (raw)
In-Reply-To: <201108311849.37273.arnd@arndb.de>
On Wed, 2011-08-31 at 18:49 +0200, Arnd Bergmann wrote:
> On Monday 29 August 2011, Luciano Coelho wrote:
> > From: Randy Dunlap <rdunlap@xenotime.net>
> >
> > Combine MFD_SUPPORT (which only enabled the remainder of the MFD
> > menu) and MFD_CORE. This allows other drivers to select MFD_CORE
> > without needing to also select MFD_SUPPORT, which fixes some
> > kconfig unmet dependency warnings. Modeled after I2C kconfig.
> >
> > [Forward-ported to 3.1-rc4. This fixes a warning when some drivers,
> > such as RADIO_WL1273, are selected, but MFD_SUPPORT is not. -- Luca]
> >
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > Reported-by: Johannes Berg <johannes@sipsolutions.net>
> > Cc: Jean Delvare <khali@linux-fr.org>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Signed-off-by: Luciano Coelho <coelho@ti.com>
> > ---
> >
> > I guess this should fix the problem. I've simple forward-ported
> > Randy's patch to the latest mainline kernel. I don't know via which
> > tree this should go in, though.
> >
> > NOTE: I have not tested this very thoroughly. But at least
> > omap2plus stuff seems to work okay with this change. MFD_SUPPORT is
> > also selected by a couple of "tile" platforms defconfigs, but I guess
> > the Kconfig system should take care of it.
>
> Doing this is a good idea, but incidentally I have just spent some time
> with the same problem and ended up with a solution that I like better,
> which is removing CONFIG_MFD_SUPPORT altogether.
>
> The point is that there is no use enabling MFD_CORE if you don't also
> enable any of the specific drivers. MFD_SUPPORT was added as a 'menuconfig'
> before we had Kconfig warn about broken dependencies, so everything was
> fine. Since Kconfig now issues the warnings, I think it would be better
> to just turn the MFD menu into a plain 'menu' and remove all the
> 'depends on MFD_SUPPORT' and 'select MFD_SUPPORT' lines from the other
> Kconfig files.
Yes, this makes sense. I think your solution is indeed cleaner. If you
want to send it it's fine with me. I don't really have any preference,
I just wanted to clean a problem that was reported to me. ;)
If you send your changes, my patch can be ignored, otherwise, I can send
a v2 with the changes Jean proposed.
--
Cheers,
Luca.
next prev parent reply other threads:[~2011-09-02 12:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 17:02 Kconfig unmet dependency with RADIO_WL1273 Luciano Coelho
2011-08-29 17:27 ` Randy Dunlap
2011-08-29 18:41 ` [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE Luciano Coelho
2011-08-29 18:54 ` Grant Likely
2011-08-31 16:18 ` Jean Delvare
2011-08-31 16:49 ` Arnd Bergmann
2011-09-02 11:54 ` Luciano Coelho [this message]
2011-09-02 12:37 ` Jean Delvare
2011-09-02 14:43 ` [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES Arnd Bergmann
2011-09-05 12:41 ` Jean Delvare
2011-09-05 14:19 ` Arnd Bergmann
2011-09-05 14:27 ` Jean Delvare
2011-09-18 15:11 ` Randy Dunlap
2011-09-18 15:28 ` Greg KH
2011-09-18 18:45 ` Randy Dunlap
2011-09-19 8:47 ` Arnd Bergmann
2011-09-19 13:07 ` Greg KH
2011-09-19 15:14 ` Arnd Bergmann
2011-09-02 14:43 ` [PATCH 2/2] mfd: remove CONFIG_MFD_SUPPORT Arnd Bergmann
2011-09-05 13:09 ` Jean Delvare
2011-09-15 15:46 ` Samuel Ortiz
2011-09-02 15:49 ` [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE Arnd Bergmann
2011-09-15 17:16 ` Grant Likely
2011-09-19 15:06 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314964495.2296.632.camel@cumari \
--to=coelho@ti.com \
--cc=arnd@arndb.de \
--cc=grant.likely@secretlab.ca \
--cc=johannes@sipsolutions.net \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=matti.j.aaltonen@nokia.com \
--cc=mchehab@infradead.org \
--cc=rdunlap@xenotime.net \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox