From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga11.intel.com ([192.55.52.93]:51387 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190Ab1ILKTq convert rfc822-to-8bit (ORCPT ); Mon, 12 Sep 2011 06:19:46 -0400 Subject: Re: [RFC][PATCH] as3645a: introduce new LED Flash driver From: Andy Shevchenko To: Laurent Pinchart Cc: "Ivan T . Ivanov" , linux-media@vger.kernel.org, Tuukka Toivonen , Sakari Ailus , Mauro Carvalho Chehab Date: Mon, 12 Sep 2011 13:19:15 +0300 In-Reply-To: <201109091708.02328.laurent.pinchart@ideasonboard.com> References: <020b9977ca7e8f0eabfe1b52b7f37a2105611605.1315580169.git.andriy.shevchenko@linux.intel.com> <201109091708.02328.laurent.pinchart@ideasonboard.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Message-ID: <1315822755.28628.49.camel@smile> Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, 2011-09-09 at 17:08 +0200, Laurent Pinchart wrote: > Hi Andy, > > On Friday 09 September 2011 16:59:31 Andy Shevchenko wrote: > > The driver supports the AS3645A, LM3555 chips and their clones. > > > > Accordingly to datasheet the AS3645 chip is a "1000/720mA Ultra Small High > > efficient single/dual LED Flash Driver with Safety Features". LM3555 is > > similar one, that has following difference - the current in the torch mode > > is the same (60mA) for the levels 0, 1, and 2. > > > > This driver is a huge rework of the previously published driver which could > > be found in the MeeGo kernel package. > > Thank you for the patch. > > I was about to send a new AS3645A driver version that supports more chip > features. I will CC you. It's nice to hear this, however, I have some comments and questions I will ask. And just out of curiosity, how many drivers do you have already done, but not published yet? I would like (and I hope you too) to avoid such double effort in the future. -- Andy Shevchenko Intel Finland Oy