Re: [PATCH v3 30/33] omap3isp: Add resizer data rate configuration to resizer_set_stream

Laurent Pinchart
2012-02-22T11:24:45Z

Hi Sakari,

Thanks for the patch.

On Monday 20 February 2012 03:57:09 Sakari Ailus wrote:
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
> ---
> drivers/media/video/omap3isp/ispresizer.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/media/video/omap3isp/ispresizer.c
> b/drivers/media/video/omap3isp/ispresizer.c index 6ce2349..81e1bc4 100644
> --- a/drivers/media/video/omap3isp/ispresizer.c
> +++ b/drivers/media/video/omap3isp/ispresizer.c
> @@ -1147,9 +1147,13 @@ static int resizer_set_stream(struct v4l2_subdev *sd,
> int enable) struct device *dev = to_device(res);
>
> if (res->state == ISP_PIPELINE_STREAM_STOPPED) {
> + struct isp_pipeline *pipe = to_isp_pipeline(&sd->entity);
> +
> if (enable == ISP_PIPELINE_STREAM_STOPPED)
> return 0;
>
> + omap3isp_resizer_max_rate(res, &pipe->max_rate);
> +
> omap3isp_subclk_enable(isp, OMAP3_ISP_SUBCLK_RESIZER);
> resizer_configure(res);
> resizer_print_status(res);

What about moving this to link validation ?

Could you please also remove it from isp_video_validate_pipeline() in this
patch ? It would make review easier.

--
Regards,

Laurent Pinchart