Re: [PATCH v3 08/33] v4l: Add subdev selections documentation: svg and dia files

Laurent Pinchart
2012-02-21T15:01:41Z

Hi Sakari,

Thanks for the patch.

On Monday 20 February 2012 03:56:47 Sakari Ailus wrote:
> Add svga and dia files for V4L2 subdev selections documentation.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>

The diagram look fine, although a bit complex. They could be simplified by
merging the identical rectangles (for instance moving the sink crop selection
label to the dotted blue rectangle, and removing the plain blue rectangle).
I'm not sure if that would be really more readable though, it's up to you.

--
Regards,

Laurent Pinchart