From: Lawrence Rust <lawrence@softsystem.co.uk>
To: Andreas Oberritter <obi@linuxtv.org>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] Revert most of 15cc2bb [media] DVB: dtv_property_cache_submit shouldn't modifiy the cache
Date: Sat, 05 Nov 2011 18:57:35 +0100 [thread overview]
Message-ID: <1320515855.1731.28.camel@gagarin> (raw)
In-Reply-To: <4EB574A3.8050503@linuxtv.org>
On Sat, 2011-11-05 at 18:38 +0100, Andreas Oberritter wrote:
[snip]
> I don't get how this could be useful. MythTV knows what delivery system
> it wants to use, so it should pass this information to the kernel.
> Trying to set an invalid delivery system must fail.
>
> Using SYS_UNDEFINED as a pre-set default is different from setting
> SYS_UNDEFINED from userspace, which should always generate an error IMO,
> unless this is documented otherwise in the API specification.
It's not ideal that MythTV is setting DTV_DELIVERY_SYSTEM to 0 and I
have filed a bug against this. But that doesn't change the fact that
the original patch significantly changed user parameter handling for no
significant benefit. MythTV is probably the biggest client of v4l and
will greatly hinder users upgrading to (Myth)Ubuntu 12.04 or Fedora 16
both of which use Linux 3.x.
--
Lawrence
next prev parent reply other threads:[~2011-11-05 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-05 15:19 [PATCH] Revert most of 15cc2bb [media] DVB: dtv_property_cache_submit shouldn't modifiy the cache Lawrence Rust
2011-11-05 16:39 ` Andreas Oberritter
2011-11-05 17:20 ` Lawrence Rust
2011-11-05 17:38 ` Andreas Oberritter
2011-11-05 17:57 ` Lawrence Rust [this message]
2011-11-24 16:38 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320515855.1731.28.camel@gagarin \
--to=lawrence@softsystem.co.uk \
--cc=linux-media@vger.kernel.org \
--cc=obi@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox