Re: [PATCH] media: video: append $(srctree) to -I parameters

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, 2012-02-16 at 07:22 +0100, Laurent Pinchart wrote: 
> Hi Andy,
> 
> Thanks for the patch.
> 
> On Wednesday 15 February 2012 17:08:01 Andy Shevchenko wrote:
> > Without this we have got the warnings like following if build with "make W=1
> > O=/var/tmp":
> >    CHECK   drivers/media/video/videobuf-vmalloc.c
> >    CC [M]  drivers/media/video/videobuf-vmalloc.o
> >  +cc1: warning: drivers/media/dvb/dvb-core: No such file or directory
> > [enabled by default] +cc1: warning: drivers/media/dvb/frontends: No such
> > file or directory [enabled by default] +cc1: warning:
> > drivers/media/dvb/dvb-core: No such file or directory [enabled by default]
> > +cc1: warning: drivers/media/dvb/frontends: No such file or directory
> > [enabled by default] LD      drivers/media/built-in.o
> > 
> > Some details could be found in [1] as well.
> > 
> > [1] http://comments.gmane.org/gmane.linux.kbuild.devel/7733
> 
> There are several occurencies if the same issue throughout drivers/. Could you 
> send a patch that fixes them all in one go ?
I guess it should be a patch series anyway to help with bisecting.
Okay, I will check it and make a patches if there any issue is found.

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/media/video/Makefile |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
> > index 3541388..3bf0aa8 100644
> > --- a/drivers/media/video/Makefile
> > +++ b/drivers/media/video/Makefile
> > @@ -199,6 +199,6 @@ obj-y	+= davinci/
> > 
> >  obj-$(CONFIG_ARCH_OMAP)	+= omap/
> > 
> > -ccflags-y += -Idrivers/media/dvb/dvb-core
> > -ccflags-y += -Idrivers/media/dvb/frontends
> > -ccflags-y += -Idrivers/media/common/tuners
> > +ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
> > +ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
> > +ccflags-y += -I$(srctree)/drivers/media/common/tuners
> 
> The above link mentions $(src). Is that different than $(srctree) ?
If I remember correctly $srctree points always to the root of the linux
kernel sources, but $src to the path of a certain Makefile.
In this case it seems $(src) == drivers/media/video. 

Moment...

Aha, the Documentation/kbuild/makefiles.txt clearly tells us:
    $(src)
        $(src) is a relative path which points to the directory
        where the Makefile is located. Always use $(src) when
        referring to files located in the src tree.


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy