From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:35572 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755974Ab2HFUlc (ORCPT ); Mon, 6 Aug 2012 16:41:32 -0400 Received: by wgbdr13 with SMTP id dr13so3160239wgb.1 for ; Mon, 06 Aug 2012 13:41:31 -0700 (PDT) Message-ID: <1344285683.12234.25.camel@router7789> Subject: Re: [PATCH] [BUG] Re: dvb_usb_lmedm04 crash Kernel (rs2000) From: Malcolm Priestley To: Antti Palosaari Cc: linux-media Date: Mon, 06 Aug 2012 21:41:23 +0100 In-Reply-To: <502010EB.7050003@iki.fi> References: <501AE90E.2020201@iki.fi> <1343950313.11458.10.camel@router7789> <502010EB.7050003@iki.fi> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org List-ID: On Mon, 2012-08-06 at 21:46 +0300, Antti Palosaari wrote: > On 08/03/2012 02:31 AM, Malcolm Priestley wrote: > > On Thu, 2012-08-02 at 23:54 +0300, Antti Palosaari wrote: > >> Moi Malcolm, > >> Any idea why this seems to crash Kernel just when device is plugged? > >> > > Hi Antti > > > > Yes, there missing error handling when no firmware file found. > > > > It seems that this is more of a problem with udev-182+. > > > > However, so far udev-182 is only a problem on first ever plug. > > > > Regards > > > > > > Malcolm > > > Aug 6 20:56:34 localhost kernel: [19094.248540] LME2510(C): Firmware > Status: 6 (44) > Aug 6 20:56:34 localhost kernel: [19094.251541] LME2510(C): FRM No > Firmware Found - please install > Aug 6 20:56:34 localhost kernel: [19094.251559] usbcore: registered new > interface driver LME2510C_DVB-S > > It is good to print needed fw name. I found it from the documentation, > Documentation/dvb/lmedm04.txt. Hi Antti, Yes, this is a good idea to print the firmware it finds and then selects. > > Could you drop me that firmware privately as I don't wish to install > Windows drivers in order to extract it. > It would be interesting to see if your firmware is newer, my two boxes are over a year old. I as sure the firmware has a bug. Regards Malcolm > > Tested-by: Antti Palosaari > > > Signed-off-by: Malcolm Priestley > > --- > > drivers/media/dvb/dvb-usb/lmedm04.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c > > index 25d1031..26ba5bc 100644 > > --- a/drivers/media/dvb/dvb-usb/lmedm04.c > > +++ b/drivers/media/dvb/dvb-usb/lmedm04.c > > @@ -878,6 +878,10 @@ static int lme_firmware_switch(struct usb_device *udev, int cold) > > fw_lme = fw_c_rs2000; > > ret = request_firmware(&fw, fw_lme, &udev->dev); > > dvb_usb_lme2510_firmware = TUNER_RS2000; > > + if (ret == 0) > > + break; > > + info("FRM No Firmware Found - please install"); > > + cold_fw = 0; > > break; > > default: > > fw_lme = fw_c_s7395; > > > > > regards > Antti > > >