From: Anatolij Gustschin <agust@denx.de>
To: linux-media@vger.kernel.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
dzu@denx.de
Subject: [PATCH 3/3] mt9v022: set y_skip_top field to zero
Date: Fri, 24 Aug 2012 11:10:31 +0200 [thread overview]
Message-ID: <1345799431-29426-4-git-send-email-agust@denx.de> (raw)
In-Reply-To: <1345799431-29426-1-git-send-email-agust@denx.de>
Set "y_skip_top" to zero and remove comment as I do not see this
line corruption on two different mt9v022 setups. The first read-out
line is perfectly fine.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
drivers/media/i2c/soc_camera/mt9v022.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/mt9v022.c b/drivers/media/i2c/soc_camera/mt9v022.c
index d26c071..e41d738 100644
--- a/drivers/media/i2c/soc_camera/mt9v022.c
+++ b/drivers/media/i2c/soc_camera/mt9v022.c
@@ -960,11 +960,7 @@ static int mt9v022_probe(struct i2c_client *client,
mt9v022->chip_control = MT9V022_CHIP_CONTROL_DEFAULT;
- /*
- * MT9V022 _really_ corrupts the first read out line.
- * TODO: verify on i.MX31
- */
- mt9v022->y_skip_top = 1;
+ mt9v022->y_skip_top = 0;
mt9v022->rect.left = MT9V022_COLUMN_SKIP;
mt9v022->rect.top = MT9V022_ROW_SKIP;
mt9v022->rect.width = MT9V022_MAX_WIDTH;
--
1.7.1
next prev parent reply other threads:[~2012-08-24 9:10 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 9:10 [PATCH 0/3] various updates for mt9v022 driver Anatolij Gustschin
2012-08-24 9:10 ` [PATCH 1/3] mt9v022: add v4l2 controls for blanking and other register settings Anatolij Gustschin
2012-08-24 11:08 ` Guennadi Liakhovetski
2012-08-24 13:04 ` Detlev Zundel
2012-08-24 13:35 ` Guennadi Liakhovetski
2012-08-24 15:44 ` Detlev Zundel
2012-08-24 16:21 ` Anatolij Gustschin
2012-08-24 21:23 ` Guennadi Liakhovetski
2012-08-28 13:43 ` Anatolij Gustschin
2012-09-11 8:24 ` Guennadi Liakhovetski
2012-09-27 21:10 ` Anatolij Gustschin
2012-08-24 13:28 ` Anatolij Gustschin
2012-09-27 22:03 ` [PATCH v2 1/3] mt9v022: add v4l2 controls for blanking Anatolij Gustschin
2012-10-06 11:00 ` Anatolij Gustschin
2012-10-09 10:32 ` Guennadi Liakhovetski
2012-08-24 9:10 ` [PATCH 2/3] mt9v022: fix the V4L2_CID_EXPOSURE control Anatolij Gustschin
2012-08-24 11:22 ` Guennadi Liakhovetski
2012-08-24 14:17 ` Anatolij Gustschin
2012-08-24 14:32 ` Guennadi Liakhovetski
2012-09-21 9:30 ` Anatolij Gustschin
2012-09-27 22:04 ` [PATCH v2 " Anatolij Gustschin
2012-08-24 9:10 ` Anatolij Gustschin [this message]
2012-08-24 11:23 ` [PATCH 3/3] mt9v022: set y_skip_top field to zero Guennadi Liakhovetski
2012-08-24 13:34 ` Anatolij Gustschin
2012-09-11 8:55 ` Guennadi Liakhovetski
2012-09-21 9:28 ` Anatolij Gustschin
2012-09-27 22:05 ` [PATCH v2 3/3] mt9v022: set y_skip_top field to zero as default Anatolij Gustschin
[not found] ` <Pine.LNX.4.64.1209281413220.5428@axis700.grange>
[not found] ` <Pine.LNX.4.64.1209281420420.5428@axis700.grange>
2012-09-29 2:21 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345799431-29426-4-git-send-email-agust@denx.de \
--to=agust@denx.de \
--cc=dzu@denx.de \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).