Re: [PATCH 4/5] video:omap3isp:fix up ENOIOCTLCMD error handling

Laurent Pinchart
2012-09-19T00:32:51Z

Hi Mauro,

On Saturday 15 September 2012 13:24:37 Mauro Carvalho Chehab wrote:
> Em Thu, 13 Sep 2012 06:03:21 +0200 Laurent Pinchart escreveu:
> > On Monday 27 August 2012 15:23:15 Wanlong Gao wrote:
> > > At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
> > > translated as ENOTTY to user mode.
> > >
> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
> > > Cc: linux-media@vger.kernel.org
> > > Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> > > ---
> > >
> > > drivers/media/video/omap3isp/ispvideo.c | 10 +++++-----
> > > 1 file changed, 5 insertions(+), 5 deletions(-)
> > >
> > > diff --git a/drivers/media/video/omap3isp/ispvideo.c
> > > b/drivers/media/video/omap3isp/ispvideo.c index b37379d..2dd982e 100644
> > > --- a/drivers/media/video/omap3isp/ispvideo.c
> > > +++ b/drivers/media/video/omap3isp/ispvideo.c
> > > @@ -337,7 +337,7 @@ __isp_video_get_format(struct isp_video *video,
> > > struct
> > > v4l2_format *format) fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
> > >
> > > ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &fmt);
> > > if (ret == -ENOIOCTLCMD)
> > >
> > > - ret = -EINVAL;
> > > + ret = -ENOTTY;
> >
> > I don't think this location should be changed. __isp_video_get_format() is
> > called by isp_video_check_format() only, which in turn is called by
> > isp_video_streamon() only. A failure to retrieve the format in
> > __isp_video_get_format() does not really mean the VIDIOC_STREAMON is not
> > supported.
> >
> > I'll apply hunks 2 to 5 and drop hunk 1 if that's fine with you.
>
> Not quite sure how to tag it at patchwork... I guess I'll mark it as
> "accepted", as, from what I understood, Laurent partially accepted it, and
> will be adding on his tree.

Yes I'll add a modified version to my tree.

--
Regards,

Laurent Pinchart