From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: unlisted-recipients:; (no To-header on input)@casper.infradead.org
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH 41/68] [media] go7007-v4l2: warning fix: index is unsigned, so it will never be below 0
Date: Sat, 27 Oct 2012 18:40:59 -0200 [thread overview]
Message-ID: <1351370486-29040-42-git-send-email-mchehab@redhat.com> (raw)
In-Reply-To: <1351370486-29040-1-git-send-email-mchehab@redhat.com>
drivers/staging/media/go7007/go7007-v4l2.c: In function 'vidioc_qbuf':
drivers/staging/media/go7007/go7007-v4l2.c:815:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
---
drivers/staging/media/go7007/go7007-v4l2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/go7007/go7007-v4l2.c b/drivers/staging/media/go7007/go7007-v4l2.c
index 980371b..a78133b 100644
--- a/drivers/staging/media/go7007/go7007-v4l2.c
+++ b/drivers/staging/media/go7007/go7007-v4l2.c
@@ -812,7 +812,7 @@ static int vidioc_qbuf(struct file *file, void *priv, struct v4l2_buffer *buf)
return retval;
mutex_lock(&gofh->lock);
- if (buf->index < 0 || buf->index >= gofh->buf_count)
+ if (buf->index >= gofh->buf_count)
goto unlock_and_return;
gobuf = &gofh->bufs[buf->index];
--
1.7.11.7
next prev parent reply other threads:[~2012-10-27 20:42 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 20:40 [PATCH 00/68] Get rid of all warnings Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 01/68] [media] siano: get rid of warning: no previous prototype Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 02/68] [media] drxd_hard: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 04/68] [media] rtl2832: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 05/68] [media] stb0899_drv: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 06/68] [media] stv0367: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 07/68] [media] tda10071: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 08/68] [media] tda18271c2dd.c: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 09/68] [media] cx18: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 10/68] [media] cx23885: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 11/68] [media] cx23885-alsa: fix a false gcc warning at dprintk() Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 12/68] [media] cx25821: get rid of warning: no previous prototype Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 13/68] [media] dm1105: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 14/68] [media] ivtv: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 15/68] [media] ivtv-ioctl.c: remove an useless check Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 16/68] [media] mantis: get rid of warning: no previous prototype Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 17/68] [media] saa7164: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 18/68] [media] radio-aimslab.c: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 19/68] [media] radio-isa: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 20/68] [media] radio-sf16fmi: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 22/68] [media] ite-cir.c: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 23/68] [media] nuvoton-cir: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 24/68] [media] nuvoton-cir: carrier detect support is broken - remove it Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 25/68] [media] max2165: get rid of warning: no previous prototype Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 26/68] [media] au0828: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 27/68] [media] cx231xx: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 28/68] [media] cx231xx-avcore: get rid of a sophisticated do-nothing code Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 29/68] [media] az6027: get rid of warning: no previous prototype Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 31/68] [media] lmedm04: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 32/68] [media] vp702x: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 33/68] [media] pvrusb2: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 34/68] [media] pwc-if: " Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 35/68] [media] pwc-if: must check vb2_queue_init() success Mauro Carvalho Chehab
2012-10-29 11:37 ` Ezequiel Garcia
2012-10-29 11:41 ` Mauro Carvalho Chehab
2012-10-29 11:44 ` Mauro Carvalho Chehab
2012-10-29 13:07 ` Ezequiel Garcia
2012-10-27 20:40 ` [PATCH 36/68] [media] dib9000: get rid of warning: no previous prototype Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 37/68] [media] gscpa: get rid of warning: suggest braces around empty body Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 38/68] [media] jeilinj: fix return of the response code Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 39/68] [media] gspca: warning fix: index is unsigned, so it will never be below 0 Mauro Carvalho Chehab
2012-10-27 20:40 ` [PATCH 40/68] [media] dt3155v4l: vb2_queue_init() can now fail. Check is required Mauro Carvalho Chehab
2012-10-27 20:40 ` Mauro Carvalho Chehab [this message]
2012-10-27 20:41 ` [PATCH 42/68] [media] dvb_frontend: Don't declare values twice at a table Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 43/68] [media] cx88: reorder inline to prevent a gcc warning Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 44/68] [media] cx88: get rid of a warning at dprintk() macro Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 45/68] [media] dmxdev: fix a comparition of unsigned expression warning Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 46/68] [media] drxk: get rid of some unused vars Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 49/68] [media] ngene: better comment unused code to avoid warnings Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 50/68] [media] saa7134,saa7164: warning: comparison of unsigned fixes Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 51/68] [media] meye: fix a warning Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 52/68] [media] m2m-deinterlace: remove unused vars Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 53/68] [media] tlg2300: index is unsigned, so never below zero Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 54/68] [media] fmdrv: better define fmdbg() macro to avoid warnings Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 55/68] [media] v4l2-common: h_bp var is unused at v4l2_detect_gtf() Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 56/68] [media] tua9001: fix a warning Mauro Carvalho Chehab
2012-11-05 21:10 ` Antti Palosaari
2012-10-27 20:41 ` [PATCH 58/68] [media] em28xx-cards: " Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 59/68] [media] s2255drv: index is always positive Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 60/68] [media] usbvision-core: fix a warning Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 61/68] [media] zr364xx: urb actual_length is unsigned Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 62/68] [media] bttv-driver: fix two warnings Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 64/68] [media] au0828-dvb: ret is never tested. Get rid of it Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 65/68] [media] soc_camera: ret is never used. get " Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 66/68] [media] fmdrv: Don't check if unsigned are below zero Mauro Carvalho Chehab
2012-10-27 20:41 ` [PATCH 67/68] fintek-cir: get rid of warning: no previous prototype Cc: Linux Media Mailing List <linux-media@vger.kernel.org> Mauro Carvalho Chehab
[not found] ` <1351370486-29040-58-git-send-email-mchehab@redhat.com>
2012-11-05 22:30 ` [PATCH 57/68] [media] anysee: fix a warning Antti Palosaari
2012-11-05 22:55 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351370486-29040-42-git-send-email-mchehab@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).