[patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

[patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

[Alexey Klimov]

Don't let Masterkit MA901 USB radio be handled by usb hid drivers.

This device will be handled by radio-ma901.c driver.

Signed-off-by: Alexey Klimov <klimov.linux@gmail.com>


diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 5de3bb3..8e06569 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2025,6 +2025,7 @@ static const struct hid_device_id hid_ignore_list[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LD, USB_DEVICE_ID_LD_HYBRID) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LD, USB_DEVICE_ID_LD_HEATCONTROL) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MADCATZ, USB_DEVICE_ID_MADCATZ_BEATPAD) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_MASTERKIT, USB_DEVICE_ID_MASTERKIT_MA901RADIO) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MCC, USB_DEVICE_ID_MCC_PMD1024LS) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MCC, USB_DEVICE_ID_MCC_PMD1208LS) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROCHIP, USB_DEVICE_ID_PICKIT1) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 1dcb76f..17aa4f6 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -533,6 +533,9 @@
 #define USB_VENDOR_ID_MADCATZ		0x0738
 #define USB_DEVICE_ID_MADCATZ_BEATPAD	0x4540
 
+#define USB_VENDOR_ID_MASTERKIT			0x16c0
+#define USB_DEVICE_ID_MASTERKIT_MA901RADIO	0x05df
+
 #define USB_VENDOR_ID_MCC		0x09db
 #define USB_DEVICE_ID_MCC_PMD1024LS	0x0076
 #define USB_DEVICE_ID_MCC_PMD1208LS	0x007a

Re: [patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

[Mauro Carvalho Chehab]

Em Fri, 28 Dec 2012 14:27:56 +0100 (CET)
Jiri Kosina <jkosina@suse.cz> escreveu:

> On Fri, 28 Dec 2012, Mauro Carvalho Chehab wrote:
> 
> > Hi Jiri,
> > 
> > There's another radio device that it is incorrectly detected as an HID driver.
> > As I'll be applying the driver's patch via the media tree, do you mind if I also
> > apply this hid patch there?
> 
> Hi Mauro,
> 
> please feel free to add
> 
> 	Acked-by: Jiri Kosina <jkosina@suse.cz>
> 
> and take the patch through your tree.

Thank you, Jiri!

Regards,
Mauro

Re: [patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

[Mauro Carvalho Chehab]

Em Thu, 28 Mar 2013 00:33:29 +0400
Alexey Klimov <klimov.linux@gmail.com> escreveu:

> On Wed, Mar 27, 2013 at 2:18 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> > On Tue, 19 Mar 2013, Alexey Klimov wrote:
> >
> >> Yes, i just checked how hid_ignore() works and prepared dirty fix to
> >> test in almost the same way like it's done for Keene usb driver. I
> >> will send correct fix in next few days.
> >
> > Any news on this, please?
> 
> Hi Jiri,
> 
> I'm very very sorry (was busy because of life). I just sent two
> patches to you, Mauro and two mail lists:
> [patch 1/2] hid: fix Masterkit MA901 hid quirks
> [patch 2/2] media: radio-ma901: return ENODEV in probe if usb_device
> doesn't match
> 
> Please check. First one for hid layer, so maybe you can take it
> directly through your tree. I hope it's not too late.
> I think Mauro will take second patch.

It is better to add both patches via the same tree. As it is badly 
affecting HID, it seems better if Jiri can apply both patches. 

Also, there's no other patch for radio-ma901 on my tree. So, 
I don't expect any conflicts if those patches got merged via hid tree.

Jiri, could you please apply both patches on your tree?

For both:
> [patch 1/2] hid: fix Masterkit MA901 hid quirks
> [patch 2/2] media: radio-ma901: return ENODEV in probe if usb_device

Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Regards,
Mauro

Re: [patch 02/03 v2] usb hid quirks for Masterkit MA901 usb radio

[Jiri Kosina]

On Fri, 29 Mar 2013, Mauro Carvalho Chehab wrote:

> > >> Yes, i just checked how hid_ignore() works and prepared dirty fix to
> > >> test in almost the same way like it's done for Keene usb driver. I
> > >> will send correct fix in next few days.
> > >
> > > Any news on this, please?
> > 
> > Hi Jiri,
> > 
> > I'm very very sorry (was busy because of life). I just sent two
> > patches to you, Mauro and two mail lists:
> > [patch 1/2] hid: fix Masterkit MA901 hid quirks
> > [patch 2/2] media: radio-ma901: return ENODEV in probe if usb_device
> > doesn't match
> > 
> > Please check. First one for hid layer, so maybe you can take it
> > directly through your tree. I hope it's not too late.
> > I think Mauro will take second patch.
> 
> It is better to add both patches via the same tree. As it is badly 
> affecting HID, it seems better if Jiri can apply both patches. 
> 
> Also, there's no other patch for radio-ma901 on my tree. So, 
> I don't expect any conflicts if those patches got merged via hid tree.
> 
> Jiri, could you please apply both patches on your tree?
> 
> For both:
> > [patch 1/2] hid: fix Masterkit MA901 hid quirks
> > [patch 2/2] media: radio-ma901: return ENODEV in probe if usb_device
> 
> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>

Absolutely. Will add your Ack and push it to Linus for 3.9 still.

Thanks,

-- 
Jiri Kosina
SUSE Labs