From: Antti Palosaari <crope@iki.fi>
To: linux-media@vger.kernel.org
Cc: Antti Palosaari <crope@iki.fi>
Subject: [PATCH RFC 10/11] dvb_usb_v2: use dummy function defines instead stub functions
Date: Mon, 10 Dec 2012 02:45:34 +0200 [thread overview]
Message-ID: <1355100335-2123-10-git-send-email-crope@iki.fi> (raw)
In-Reply-To: <1355100335-2123-1-git-send-email-crope@iki.fi>
I think it is better (cheaper) to use dummy defines for functions
that has no meaning when remote controller is disabled by Kconfig.
Signed-off-by: Antti Palosaari <crope@iki.fi>
---
drivers/media/usb/dvb-usb-v2/dvb_usb_core.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c b/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c
index 94f134c..1330c64 100644
--- a/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c
+++ b/drivers/media/usb/dvb-usb-v2/dvb_usb_core.c
@@ -204,15 +204,8 @@ static int dvb_usbv2_remote_exit(struct dvb_usb_device *d)
return 0;
}
#else
-static int dvb_usbv2_remote_init(struct dvb_usb_device *d)
-{
- return 0;
-}
-
-static int dvb_usbv2_remote_exit(struct dvb_usb_device *d)
-{
- return 0;
-}
+ #define dvb_usbv2_remote_init(args...) 0
+ #define dvb_usbv2_remote_exit(args...)
#endif
static void dvb_usb_data_complete(struct usb_data_stream *stream, u8 *buf,
--
1.7.11.7
next prev parent reply other threads:[~2012-12-10 0:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 0:45 [PATCH RFC 01/11] dvb_usb_v2: make remote controller optional Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 02/11] rtl28xxu: " Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 03/11] anysee: " Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 04/11] af9015: " Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 05/11] af9035: " Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 06/11] az6007: " Antti Palosaari
2012-12-10 17:22 ` Mauro Carvalho Chehab
2012-12-10 0:45 ` [PATCH RFC 07/11] it913x: " Antti Palosaari
2013-01-01 21:16 ` Antti Palosaari
2013-01-02 3:24 ` Fabio Estevam
2013-01-02 10:44 ` Antti Palosaari
2012-12-10 0:45 ` [PATCH RFC 08/11] it913x: remove unused define and increase module version Antti Palosaari
2012-12-10 19:02 ` Malcolm Priestley
2012-12-10 0:45 ` [PATCH RFC 09/11] dvb_usb_v2: remove rc-core stub implementations Antti Palosaari
2012-12-10 0:45 ` Antti Palosaari [this message]
2012-12-10 0:45 ` [PATCH RFC 11/11] dvb_usb_v2: change rc polling active/deactive logic Antti Palosaari
2013-01-06 12:11 ` [PATCH RFC 01/11] dvb_usb_v2: make remote controller optional Mauro Carvalho Chehab
2013-01-06 12:16 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355100335-2123-10-git-send-email-crope@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).