linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Albert Wang <twang13@marvell.com>
To: corbet@lwn.net, g.liakhovetski@gmx.de
Cc: linux-media@vger.kernel.org, Libin Yang <lbyang@marvell.com>,
	Albert Wang <twang13@marvell.com>
Subject: [PATCH V3 05/15] [media] marvell-ccic: refine mcam_set_contig_buffer function
Date: Sat, 15 Dec 2012 17:57:54 +0800	[thread overview]
Message-ID: <1355565484-15791-6-git-send-email-twang13@marvell.com> (raw)
In-Reply-To: <1355565484-15791-1-git-send-email-twang13@marvell.com>

From: Libin Yang <lbyang@marvell.com>

This patch refines mcam_set_contig_buffer() in mcam core

Signed-off-by: Albert Wang <twang13@marvell.com>
Signed-off-by: Libin Yang <lbyang@marvell.com>
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
 drivers/media/platform/marvell-ccic/mcam-core.c |   21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c b/drivers/media/platform/marvell-ccic/mcam-core.c
index 19e91c5..3cc1d0c 100755
--- a/drivers/media/platform/marvell-ccic/mcam-core.c
+++ b/drivers/media/platform/marvell-ccic/mcam-core.c
@@ -486,22 +486,21 @@ static void mcam_set_contig_buffer(struct mcam_camera *cam, int frame)
 	 */
 	if (list_empty(&cam->buffers)) {
 		buf = cam->vb_bufs[frame ^ 0x1];
-		cam->vb_bufs[frame] = buf;
-		mcam_reg_write(cam, frame == 0 ? REG_Y0BAR : REG_Y1BAR,
-				vb2_dma_contig_plane_dma_addr(&buf->vb_buf, 0));
 		set_bit(CF_SINGLE_BUFFER, &cam->flags);
 		cam->frame_state.singles++;
-		return;
+	} else {
+		/*
+		 * OK, we have a buffer we can use.
+		 */
+		buf = list_first_entry(&cam->buffers, struct mcam_vb_buffer,
+					queue);
+		list_del_init(&buf->queue);
+		clear_bit(CF_SINGLE_BUFFER, &cam->flags);
 	}
-	/*
-	 * OK, we have a buffer we can use.
-	 */
-	buf = list_first_entry(&cam->buffers, struct mcam_vb_buffer, queue);
-	list_del_init(&buf->queue);
+
+	cam->vb_bufs[frame] = buf;
 	mcam_reg_write(cam, frame == 0 ? REG_Y0BAR : REG_Y1BAR,
 			vb2_dma_contig_plane_dma_addr(&buf->vb_buf, 0));
-	cam->vb_bufs[frame] = buf;
-	clear_bit(CF_SINGLE_BUFFER, &cam->flags);
 }
 
 /*
-- 
1.7.9.5


  parent reply	other threads:[~2012-12-15  9:59 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-15  9:57 [PATCH V3 00/15] [media] marvell-ccic: add soc camera support on marvell-ccic Albert Wang
2012-12-15  9:57 ` [PATCH V3 01/15] [media] marvell-ccic: use internal variable replace global frame stats variable Albert Wang
2012-12-16 15:36   ` Jonathan Corbet
2012-12-27 20:07     ` Mauro Carvalho Chehab
2013-01-01 14:56   ` Guennadi Liakhovetski
2012-12-15  9:57 ` [PATCH V3 02/15] [media] marvell-ccic: add MIPI support for marvell-ccic driver Albert Wang
2012-12-16 15:54   ` Jonathan Corbet
2012-12-16 21:45     ` Albert Wang
2013-01-01 15:28   ` Guennadi Liakhovetski
2013-01-01 19:31     ` Albert Wang
2012-12-15  9:57 ` [PATCH V3 03/15] [media] marvell-ccic: add clock tree " Albert Wang
2012-12-16 16:03   ` Jonathan Corbet
2012-12-16 21:51     ` Albert Wang
2013-01-03 17:37       ` Nicolas THERY
2013-01-03 19:27         ` Albert Wang
2013-01-01 16:05   ` Guennadi Liakhovetski
2013-01-01 19:36     ` Albert Wang
2013-01-04  5:42     ` Libin Yang
2013-01-04 10:25       ` Guennadi Liakhovetski
2013-01-05  3:12         ` Libin Yang
2012-12-15  9:57 ` [PATCH V3 04/15] [media] marvell-ccic: reset ccic phy when stop streaming for stability Albert Wang
2012-12-16 16:04   ` Jonathan Corbet
2013-01-01 16:13   ` Guennadi Liakhovetski
2012-12-15  9:57 ` Albert Wang [this message]
2012-12-16 16:06   ` [PATCH V3 05/15] [media] marvell-ccic: refine mcam_set_contig_buffer function Jonathan Corbet
2012-12-16 21:54     ` Albert Wang
2012-12-15  9:57 ` [PATCH V3 06/15] [media] marvell-ccic: add new formats support for marvell-ccic driver Albert Wang
2012-12-16 16:16   ` Jonathan Corbet
2012-12-16 21:58     ` Albert Wang
2013-01-01 16:56   ` Guennadi Liakhovetski
2013-01-01 19:42     ` Albert Wang
2013-01-01 20:03       ` Guennadi Liakhovetski
2013-01-04  9:32     ` Libin Yang
2013-01-10  7:53     ` Libin Yang
2012-12-15  9:57 ` [PATCH V3 07/15] [media] marvell-ccic: add SOF / EOF pair check " Albert Wang
2012-12-16 16:19   ` Jonathan Corbet
2012-12-16 22:00     ` Albert Wang
2013-01-02  7:48   ` Guennadi Liakhovetski
2012-12-15  9:57 ` [PATCH V3 08/15] [media] marvell-ccic: switch to resource managed allocation and request Albert Wang
2012-12-16 16:20   ` Jonathan Corbet
2013-01-02  8:00   ` Guennadi Liakhovetski
2012-12-15  9:57 ` [PATCH V3 09/15] [media] marvell-ccic: add get_mcam function for marvell-ccic driver Albert Wang
2012-12-16 16:24   ` Jonathan Corbet
2012-12-16 22:04     ` Albert Wang
2013-01-02  8:16     ` Guennadi Liakhovetski
2012-12-15  9:57 ` [PATCH V3 10/15] [media] marvell-ccic: split mcam-core into 2 parts for soc_camera support Albert Wang
2012-12-16 16:37   ` Jonathan Corbet
2012-12-16 22:12     ` Albert Wang
2012-12-17 15:28       ` Jonathan Corbet
2012-12-18  3:04         ` Albert Wang
2012-12-18 19:15           ` Jonathan Corbet
2012-12-18 20:48             ` Albert Wang
2013-01-31  8:29             ` Albert Wang
2013-02-05  3:14               ` Jonathan Corbet
2013-02-06  3:21                 ` Albert Wang
2012-12-15  9:58 ` [PATCH V3 11/15] [media] marvell-ccic: add soc_camera support in mcam core Albert Wang
2012-12-15  9:58 ` [PATCH V3 12/15] [media] marvell-ccic: add soc_camera support in mmp driver Albert Wang
2012-12-16 16:46   ` Jonathan Corbet
2012-12-16 22:19     ` Albert Wang
2012-12-15  9:58 ` [PATCH V3 13/15] [media] marvell-ccic: add dma burst mode support in marvell-ccic driver Albert Wang
2012-12-16 16:49   ` Jonathan Corbet
2012-12-16 22:22     ` Albert Wang
2012-12-15  9:58 ` [PATCH V3 14/15] [media] marvell-ccic: use unsigned int type replace int type Albert Wang
2012-12-16 16:50   ` Jonathan Corbet
2012-12-15  9:58 ` [PATCH V3 15/15] [media] marvell-ccic: add 3 frame buffers support in DMA_CONTIG mode Albert Wang
2012-12-16 16:56   ` Jonathan Corbet
2012-12-16 22:34     ` Albert Wang
2012-12-16 22:55       ` Jonathan Corbet
2012-12-17  5:06         ` Albert Wang
2012-12-16 16:57 ` [PATCH V3 00/15] [media] marvell-ccic: add soc camera support on marvell-ccic Jonathan Corbet
2012-12-16 22:34   ` Albert Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355565484-15791-6-git-send-email-twang13@marvell.com \
    --to=twang13@marvell.com \
    --cc=corbet@lwn.net \
    --cc=g.liakhovetski@gmx.de \
    --cc=lbyang@marvell.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).