From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Subject: [PATCH 2/3] uvcvideo: Cleanup leftovers of partial revert
Date: Fri, 11 Jan 2013 14:13:59 +0100 [thread overview]
Message-ID: <1357910040-27463-3-git-send-email-laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <1357910040-27463-1-git-send-email-laurent.pinchart@ideasonboard.com>
Commit ba68c8530a263dc4de440fa10bb20a1c5b9d4ff5 (Partly revert "[media]
uvcvideo: Set error_idx properly for extended controls API failures")
missed two modifications. Clean them up.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
drivers/media/usb/uvc/uvc_v4l2.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v4l2.c
index f2ee8c6..5eb8989 100644
--- a/drivers/media/usb/uvc/uvc_v4l2.c
+++ b/drivers/media/usb/uvc/uvc_v4l2.c
@@ -657,8 +657,7 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
ret = uvc_ctrl_get(chain, ctrl);
if (ret < 0) {
uvc_ctrl_rollback(handle);
- ctrls->error_idx = ret == -ENOENT
- ? ctrls->count : i;
+ ctrls->error_idx = i;
return ret;
}
}
@@ -686,9 +685,7 @@ static long uvc_v4l2_do_ioctl(struct file *file, unsigned int cmd, void *arg)
ret = uvc_ctrl_set(chain, ctrl);
if (ret < 0) {
uvc_ctrl_rollback(handle);
- ctrls->error_idx = (ret == -ENOENT &&
- cmd == VIDIOC_S_EXT_CTRLS)
- ? ctrls->count : i;
+ ctrls->error_idx = i;
return ret;
}
}
--
1.7.8.6
next prev parent reply other threads:[~2013-01-11 13:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 13:13 [PATCH 0/3] Fix uvcvideo revert leftovers Laurent Pinchart
2013-01-11 13:13 ` [PATCH 1/3] uvcvideo: Return -EACCES when trying to access a read/write-only control Laurent Pinchart
2013-01-11 13:21 ` Hans Verkuil
2013-01-11 13:26 ` Hans Verkuil
2013-01-11 13:31 ` Laurent Pinchart
2013-01-11 13:13 ` Laurent Pinchart [this message]
2013-01-11 13:22 ` [PATCH 2/3] uvcvideo: Cleanup leftovers of partial revert Hans Verkuil
2013-01-11 13:14 ` [PATCH 3/3] uvcvideo: Set error_idx properly for S_EXT_CTRLS failures Laurent Pinchart
2013-01-11 13:27 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357910040-27463-3-git-send-email-laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).