From: "Frank Schäfer" <fschaefer.oss@googlemail.com>
To: mchehab@redhat.com
Cc: linux-media@vger.kernel.org,
"Frank Schäfer" <fschaefer.oss@googlemail.com>
Subject: [PATCH 0/7] em28xx-input: remove the dependency on module ir-kbd-i2c
Date: Sun, 13 Jan 2013 15:21:59 +0100 [thread overview]
Message-ID: <1358086919-7066-1-git-send-email-fschaefer.oss@googlemail.com> (raw)
As it has been decided that i2-kbd-i2c isn't the way to go for i2c IR RC
devices, remove the dependency on this module from the em28xx driver.
We already use our own key polling functions with ir-kbd-i2c and the polling
infrastructure is already on board, too (currently used for internal devices only).
To avoid the risk of breaking things, just use the same key reporting mechanism
as ir-i2c-kbd.
The last two patches are optional, as they reduce the code size by ~20 lines
at the cost of a minor performance drawback.
Tested with device "Terratec Cinergy 200 USB"
Patches 1+2: preparation
Patch 3: actual dependency removal
Patches 4+5: clean-up, comment/coding style fixes
Patches 6+7: code size optimizations (optional)
Frank Schäfer (7):
em28xx-input: remove dead code line from em28xx_get_key_em_haup()
em28xx: remove i2cdprintk() messages
em28xx: get rid of the dependency on module ir-kbd-i2c
em28xx: remove unused parameter ir_raw from i2c RC key polling
functions
em28xx: fix a comment and a small coding style issue
em28xx: i2c RC devices: minor code size and memory usage optimization
em28xx: input: use common work_struct callback function for IR RC key
polling
drivers/media/usb/em28xx/em28xx-input.c | 230 ++++++++++++++++---------------
drivers/media/usb/em28xx/em28xx.h | 3 -
2 Dateien geändert, 116 Zeilen hinzugefügt(+), 117 Zeilen entfernt(-)
--
1.7.10.4
reply other threads:[~2013-01-13 14:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358086919-7066-1-git-send-email-fschaefer.oss@googlemail.com \
--to=fschaefer.oss@googlemail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).