linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: unlisted-recipients:; (no To-header on input)@casper.infradead.org
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH RFCv10 00/15] DVB QoS statistics API
Date: Tue, 15 Jan 2013 00:30:46 -0200	[thread overview]
Message-ID: <1358217061-14982-1-git-send-email-mchehab@redhat.com> (raw)

Add DVBv5 methods to retrieve QoS statistics.

Those methods allow per-layer and global statistics.

Implemented 2 QoS statistics on mb86a20s, one global only
(signal strengh), and one per layer (BER).

Tested with a modified version of dvbv5-zap, that allows monitoring
those stats. Test data follows

Tested with 1-segment at layer A, and 12-segment at layer B:

[ 3735.973058] i2c i2c-4: mb86a20s_layer_bitrate: layer A bitrate: 440 kbps; counter = 196608 (0x030000)
[ 3735.976803] i2c i2c-4: mb86a20s_layer_bitrate: layer B bitrate: 16851 kbps; counter = 8257536 (0x7e0000)

a) Global stats:

Signal strength:
	QOS_SIGNAL_STRENGTH[0] = 4096

BER (sum of BE count and bit counts for both layers):
	QOS_BIT_ERROR_COUNT[0] = 1087865
	QOS_TOTAL_BITS_COUNT[0] = 67043313

b) Per-layer stats:

Layer A BER:
	QOS_BIT_ERROR_COUNT[1] = 236
	QOS_TOTAL_BITS_COUNT[1] = 917490

Layer B BER:
	QOS_BIT_ERROR_COUNT[2] = 1087629
	QOS_TOTAL_BITS_COUNT[2] = 66125823

TODO:
	- add more statistics at mb86a20s;
	- implement support for DTV_QOS_ENUM;
	- some cleanups at get_frontend logic at dvb core, to avoid
	  it to be called outside the DVB thread loop.

All the above changes can be done a little later during this development
cycle, so my plan is to merge it upstream at the beginning of the 
next week, to allow others to test.

I added an ugly hack on my experimental v4l-utils tree, to allow
testing it:
	http://git.linuxtv.org/mchehab/experimental-v4l-utils.git/shortlog/refs/heads/stats

GIT url for it is:
	git://linuxtv.org/mchehab/experimental-v4l-utils.git stats


---

    v6: Add DocBook documentation.
    v7: Some fixes as suggested by Antti
    v8: Documentation fix, compilation fix and name the stats struct,
        for its reusage inside the core
    v9: counters need 32 bits. So, change the return data types to
        s32/u32 types
    v10: Counters changed to 64 bits for monotonic increment
	 Don't create a separate get_stats callback. get_frontend
	 is already good enough for it.


Mauro Carvalho Chehab (15):
  mb86a20s: improve error handling at get_frontend
  dvb: Add DVBv5 stats properties for Quality of Service
  dvb: the core logic to handle the DVBv5 QoS properties
  mb86a20s: Update QoS statistics at FE read_status
  mb86a20s: functions reorder
  mb86a20s: Fix i2c gate on error
  mb86a20s: improve debug for RF level
  mb86a20s: fix interleaving and FEC retrival
  mb86a20s: convert it to use dev_info/dev_err/dev_dbg
  mb86a20s: -EBUSY is expected when getting QoS measures
  mb86a20s: make AGC work better
  mb86a20s: Some improvements for BER measurement
  mb86a20s: improve bit error count for BER
  dvb: increase API version
  mb86a20s: global stat is just a sum, and not an increment

 Documentation/DocBook/media/dvb/dvbapi.xml      |    2 +-
 Documentation/DocBook/media/dvb/dvbproperty.xml |  115 ++-
 drivers/media/dvb-core/dvb_frontend.c           |   53 ++
 drivers/media/dvb-core/dvb_frontend.h           |   11 +
 drivers/media/dvb-frontends/mb86a20s.c          | 1024 ++++++++++++++++++-----
 include/uapi/linux/dvb/frontend.h               |   83 +-
 include/uapi/linux/dvb/version.h                |    2 +-
 7 files changed, 1066 insertions(+), 224 deletions(-)

-- 
1.7.11.7


             reply	other threads:[~2013-01-15  2:31 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-15  2:30 Mauro Carvalho Chehab [this message]
2013-01-15  2:30 ` [PATCH RFCv10 01/15] mb86a20s: improve error handling at get_frontend Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 02/15] dvb: Add DVBv5 stats properties for Quality of Service Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 03/15] dvb: the core logic to handle the DVBv5 QoS properties Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 04/15] mb86a20s: Update QoS statistics at FE read_status Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 05/15] mb86a20s: functions reorder Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 06/15] mb86a20s: Fix i2c gate on error Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 07/15] mb86a20s: improve debug for RF level Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 08/15] mb86a20s: fix interleaving and FEC retrival Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 09/15] mb86a20s: convert it to use dev_info/dev_err/dev_dbg Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 10/15] mb86a20s: -EBUSY is expected when getting QoS measures Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 11/15] mb86a20s: make AGC work better Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 12/15] mb86a20s: Some improvements for BER measurement Mauro Carvalho Chehab
2013-01-15  2:30 ` [PATCH RFCv10 13/15] mb86a20s: improve bit error count for BER Mauro Carvalho Chehab
2013-01-15  2:31 ` [PATCH RFCv10 14/15] dvb: increase API version Mauro Carvalho Chehab
2013-01-15  8:20 ` [PATCH RFCv10 00/15] DVB QoS statistics API Johannes Stezenbach
2013-01-15  8:55   ` Antti Palosaari
2013-01-15 12:23     ` Mauro Carvalho Chehab
2013-01-15  9:34 ` Antti Palosaari
2013-01-15 13:10   ` Mauro Carvalho Chehab
2013-01-15 14:49     ` Antti Palosaari
2013-01-15 15:21       ` Mauro Carvalho Chehab
2013-01-15 15:47         ` Devin Heitmueller
2013-01-15 17:02           ` Mauro Carvalho Chehab
2013-01-15 15:26       ` Antti Palosaari
2013-01-15 17:12         ` Mauro Carvalho Chehab
2013-01-15 20:37           ` Antti Palosaari
2013-01-16  4:26             ` Manu Abraham
2013-01-16 11:41               ` Luca Olivetti
2013-01-16 13:56               ` Mauro Carvalho Chehab
2013-01-16 15:19                 ` Manu Abraham
2013-01-16 17:21                   ` Mauro Carvalho Chehab
2013-01-16 18:26                     ` Manu Abraham
2013-01-16 19:22                       ` Mauro Carvalho Chehab
2013-01-16 21:40                         ` Manu Abraham
2013-01-16 19:29                       ` Simon Farnsworth
2013-01-16 21:37                         ` Manu Abraham
2013-01-16 22:11                           ` Mauro Carvalho Chehab
2013-01-17  3:26                             ` Manu Abraham
2013-01-16 22:01                         ` Mauro Carvalho Chehab
2013-01-17  3:40                           ` Manu Abraham
2013-01-17  9:33                             ` Antti Palosaari
2013-01-17 16:50                               ` Mauro Carvalho Chehab
2013-01-17 17:15                                 ` Antti Palosaari
2013-01-17 18:11                                   ` Mauro Carvalho Chehab
2013-01-17 18:27                                     ` Antti Palosaari
2013-01-17 18:37                                       ` Manu Abraham
2013-01-17 18:50                                         ` Mauro Carvalho Chehab
2013-01-17 19:11                                           ` Antti Palosaari
2013-01-17 19:35                                             ` Mauro Carvalho Chehab
2013-01-17 21:29                                             ` Manu Abraham
2013-01-17 22:22                                               ` Antti Palosaari
2013-01-17 22:46                                                 ` Mauro Carvalho Chehab
2013-01-22 12:16                                             ` Mauro Carvalho Chehab
2013-01-23 15:08                                               ` Antti Palosaari
2013-01-23 15:12                                                 ` Antti Palosaari
2013-01-23 18:18                                                 ` Mauro Carvalho Chehab
2013-01-23 18:57                                                   ` Mauro Carvalho Chehab
2013-01-23 19:55                                                     ` Antti Palosaari
2013-01-23 21:00                                                       ` Mauro Carvalho Chehab
2013-01-23 22:02                                                         ` Mauro Carvalho Chehab
2013-01-17 17:16                               ` Manu Abraham
2013-01-17 17:22                                 ` Antti Palosaari
2013-01-17 17:37                                   ` [linux-media] " Klaus Schmidinger
2013-01-17 17:39                                     ` [linux-media] " Klaus Schmidinger
2013-01-17 18:36                                   ` Mauro Carvalho Chehab
2013-01-19 12:04                           ` Mauro Carvalho Chehab
2013-01-16 13:24             ` Mauro Carvalho Chehab
2013-01-15 10:38 ` Manu Abraham
2013-01-15 15:23   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358217061-14982-1-git-send-email-mchehab@redhat.com \
    --to=mchehab@redhat.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).