Re: [REVIEW PATCH 11/12] em28xx: make ioctl VIDIOC_DBG_G_CHIP_IDENT available for radio devices

Frank Schäfer
2013-01-29T17:37:40Z

Am 28.01.2013 11:00, schrieb Hans Verkuil:
> On Fri January 25 2013 18:27:01 Frank Schäfer wrote:
>> Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
>> ---
>> drivers/media/usb/em28xx/em28xx-video.c | 1 +
>> 1 Datei geändert, 1 Zeile hinzugefügt(+)
>>
>> diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c
>> index dd05cfb..e97b095 100644
>> --- a/drivers/media/usb/em28xx/em28xx-video.c
>> +++ b/drivers/media/usb/em28xx/em28xx-video.c
>> @@ -1695,6 +1695,7 @@ static const struct v4l2_ioctl_ops radio_ioctl_ops = {
>> #ifdef CONFIG_VIDEO_ADV_DEBUG
>> .vidioc_g_register = vidioc_g_register,
>> .vidioc_s_register = vidioc_s_register,
>> + .vidioc_g_chip_ident = vidioc_g_chip_ident,
>> #endif
>> };
>>
>>
> g_chip_ident can be moved out of ADV_DEBUG, both for video and radio devices.

Yes it can but I wasn't sure if we really should change it.
Anyway, with your vote for changing it, I will be glad to send a patch
(it's an additional change and I don't need to send a V2 of the series
then, which also makes life easier for Mauro).

Regards,
Frank

> Regards,
>
> Hans