Re: [REVIEW PATCH 00/12] em28xx: ioctl fixes/clean-ups

Hans Verkuil
2013-01-28T10:01:59Z

On Fri January 25 2013 18:26:50 Frank Schäfer wrote:
> This patch series addresses some issues with the ioctl code of the em28xx driver:
> Patches 1-5 and 11 fix and clean up the enabling/disabling of the ioctls
> depending on the device type and equipment.
> Patches 6-10 remove some obsolete/useless code.
> Patch 12 improves the VBI support detection and device node registration.
>
>
> Frank Schäfer (12):
> em28xx: use v4l2_disable_ioctl() to disable ioctls VIDIOC_QUERYSTD,
> VIDIOC_G/S_STD
> em28xx: disable tuner related ioctls for video and VBI devices
> without tuner
> em28xx: use v4l2_disable_ioctl() to disable ioctls VIDIOC_G_AUDIO and
> VIDIOC_S_AUDIO
> em28xx: use v4l2_disable_ioctl() to disable ioctl VIDIOC_S_PARM
> em28xx: disable ioctl VIDIOC_S_PARM for VBI devices
> em28xx: make ioctls VIDIOC_G/S_PARM working for VBI devices
> em28xx: remove ioctl VIDIOC_CROPCAP
> em28xx: get rid of duplicate function vidioc_s_fmt_vbi_cap()
> em28xx: VIDIOC_G_TUNER: remove unneeded setting of tuner type
> em28xx: remove obsolete device state checks from the ioctl functions
> em28xx: make ioctl VIDIOC_DBG_G_CHIP_IDENT available for radio
> devices
> em28xx: do not claim VBI support if the device is a camera
>
> drivers/media/usb/em28xx/em28xx-core.c | 5 ++
> drivers/media/usb/em28xx/em28xx-video.c | 147 +++++++------------------------
> 2 Dateien geändert, 35 Zeilen hinzugefügt(+), 117 Zeilen entfernt(-)
>
>

After fixing the small comment I made for patch 11/12 you can add my Acked-by
for this patch series.

Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

Regards,

Hans