From: Prabhakar Lad <prabhakar.csengg@gmail.com>
To: Hans Verkuil <hans.verkuil@cisco.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
LMML <linux-media@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: DLOS <davinci-linux-open-source@linux.davincidsp.com>,
LKML <linux-kernel@vger.kernel.org>,
"Lad, Prabhakar" <prabhakar.csengg@gmail.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>
Subject: [PATCH v2 2/4] media: i2c: ths7303: remove init_enable option from pdata
Date: Sat, 25 May 2013 23:09:34 +0530 [thread overview]
Message-ID: <1369503576-22271-3-git-send-email-prabhakar.csengg@gmail.com> (raw)
In-Reply-To: <1369503576-22271-1-git-send-email-prabhakar.csengg@gmail.com>
From: Lad, Prabhakar <prabhakar.csengg@gmail.com>
This patch removes init_enable option from pdata, the init_enable
was intended that the device should start streaming video immediately
but ideally the bridge drivers should call s_stream explicitly for such
devices to start video.
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-kernel@vger.kernel.org
Cc: davinci-linux-open-source@linux.davincidsp.com
---
drivers/media/i2c/ths7303.c | 4 +---
include/media/ths7303.h | 2 --
2 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/ths7303.c b/drivers/media/i2c/ths7303.c
index 65853ee..8cddcd0 100644
--- a/drivers/media/i2c/ths7303.c
+++ b/drivers/media/i2c/ths7303.c
@@ -356,9 +356,7 @@ static int ths7303_setup(struct v4l2_subdev *sd)
int ret;
u8 mask;
- state->stream_on = pdata->init_enable;
-
- mask = state->stream_on ? 0xff : 0xf8;
+ mask = 0xf8;
ret = ths7303_write(sd, THS7303_CHANNEL_1, pdata->ch_1 & mask);
if (ret)
diff --git a/include/media/ths7303.h b/include/media/ths7303.h
index 980ec51..a7b4929 100644
--- a/include/media/ths7303.h
+++ b/include/media/ths7303.h
@@ -30,13 +30,11 @@
* @ch_1: Bias value for channel one.
* @ch_2: Bias value for channel two.
* @ch_3: Bias value for channel three.
- * @init_enable: initalize on init.
*/
struct ths7303_platform_data {
u8 ch_1;
u8 ch_2;
u8 ch_3;
- u8 init_enable;
};
#endif
--
1.7.0.4
next prev parent reply other threads:[~2013-05-25 17:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-25 17:39 [PATCH v2 0/4] media: i2c: ths7303 cleanup Prabhakar Lad
2013-05-25 17:39 ` [PATCH v2 1/4] ARM: davinci: dm365 evm: remove init_enable from ths7303 pdata Prabhakar Lad
2013-05-25 17:43 ` Prabhakar Lad
2013-05-31 8:43 ` Prabhakar Lad
2013-06-06 4:36 ` Sekhar Nori
2013-06-06 10:02 ` Prabhakar Lad
2013-06-06 10:07 ` Sekhar Nori
2013-05-25 17:39 ` Prabhakar Lad [this message]
2013-05-25 17:39 ` [PATCH v2 3/4] media: i2c: ths7303: remove unnecessary function ths7303_setup() Prabhakar Lad
2013-05-25 17:39 ` [PATCH v2 4/4] media: i2c: ths7303: make the pdata as a constant pointer Prabhakar Lad
2013-05-26 1:20 ` [PATCH v2 0/4] media: i2c: ths7303 cleanup Laurent Pinchart
2013-06-06 10:05 ` Prabhakar Lad
2013-06-07 8:40 ` Hans Verkuil
2013-06-08 8:04 ` Prabhakar Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369503576-22271-3-git-send-email-prabhakar.csengg@gmail.com \
--to=prabhakar.csengg@gmail.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox