From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jarod Wilson <jarod@wilsonet.com>,
Mauro Carvalho Chehab <mchehab@redhat.com>,
YAMANE Toshiaki <yamanetoshi@gmail.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] staging: lirc: clean error handling in probe()
Date: Wed, 26 Jun 2013 18:29:12 +0300 [thread overview]
Message-ID: <1372260552.24799.59.camel@smile> (raw)
In-Reply-To: <20130626151001.GM5714@mwanda>
On Wed, 2013-06-26 at 18:10 +0300, Dan Carpenter wrote:
> On Wed, Jun 26, 2013 at 05:37:36PM +0300, Andy Shevchenko wrote:
> > From: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > We have reorganized the error handling into a simpler and more canonical
> > format.
> >
> > Additionally we removed extra empty lines, switched to devm_kzalloc(), and
> > substitute 'minor' by 'ret' in the igorplugusb_remote_probe() function.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> I don't want credit for this, because I didn't do the work.
> Signed-off-by is a legal thing like signing a document...
I took your patch and modified it, so, you have done some work too.
But I could resend a version with my authorship.
> But I
> have reviewed it and it looks good.
>
> Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> regards,
> dan carpenter
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-06-26 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-26 14:37 [PATCH v2] staging: lirc: clean error handling in probe() Andy Shevchenko
2013-06-26 15:10 ` Dan Carpenter
2013-06-26 15:29 ` Andy Shevchenko [this message]
2013-06-26 15:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372260552.24799.59.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=jarod@wilsonet.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox