From: Maxim Levitsky <maximlevitsky@gmail.com>
To: linux-media@vger.kernel.org
Subject: rc: ene_ir: few fixes
Date: Mon, 8 Jul 2013 03:22:44 +0300 [thread overview]
Message-ID: <1373242968-16055-1-git-send-email-maximlevitsky@gmail.com> (raw)
Hi,
Could you consider merging few fixes to my driver:
1. Fix accidently introduced error, that is the hardware is a bit unusual
in the way that it needs the interrupt number, and one of the recent patches
moved the irq number read to be too late for that.
2. I just now played with my remote that wakes the system, and noticed that
it wakes the system even if I disable the wake bit.
Just disable the device if wake is disabled, and this fixes the issue.
3. I noticed that debug prints from my driver don't work anymore,
and this is due to conversion to pr_dbg, which is in my opinion too restructive in
enabling it.
If you allow, I want to use pr_info instead.
patch #1 should go to stable as well, as it outright breaks my driver.
PS: I am very short on time, and I will be free in about month, after I pass
another round of exams.
Best regards,
Maxim Levitsky
next reply other threads:[~2013-07-08 0:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 0:22 Maxim Levitsky [this message]
2013-07-08 0:22 ` [PATCH 1/3] ene_ir: Fix interrupt line passthrough to hardware Maxim Levitsky
2013-07-08 0:22 ` [PATCH 2/3] ene_ir: disable the device if wake is disabled It doesn't hurt and on my notebook despite clearing the wake flag the remote still wakes up the system. This way it doesn't Maxim Levitsky
2013-07-08 0:22 ` [PATCH 3/3] ene_ir: don't use pr_debug after all Maxim Levitsky
2013-07-11 0:29 ` rc: ene_ir: few fixes Maxim Levitsky
2013-07-15 7:09 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373242968-16055-1-git-send-email-maximlevitsky@gmail.com \
--to=maximlevitsky@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox