Re: [PATCH] vb2: Add debug print for the output buffer planes lengths checks

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sylwester,

Thank you for the patch.

On Monday 26 August 2013 17:47:53 Sylwester Nawrocki wrote:
> Add debug print so it's easier to find any errors resulting from
> the planes' configuration checks added in commit 8023ed09cb278004a2
> "videobuf2-core: Verify planes lengths for output buffers".
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/v4l2-core/videobuf2-core.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c
> b/drivers/media/v4l2-core/videobuf2-core.c index de0e87f..6bffc96 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -1205,8 +1205,11 @@ static int __buf_prepare(struct vb2_buffer *vb, const
> struct v4l2_buffer *b) int ret;
> 
>  	ret = __verify_length(vb, b);
> -	if (ret < 0)
> +	if (ret < 0) {
> +		dprintk(1, "%s(): plane parameters verification failed: %d\n",
> +			__func__, ret);
>  		return ret;
> +	}
> 
>  	switch (q->memory) {
>  	case V4L2_MEMORY_MMAP:
-- 
Regards,

Laurent Pinchart