* [PATCH] [media] radio-shark: Mark shark_resume_leds() inline to kill compiler warning
@ 2013-10-28 12:16 Geert Uytterhoeven
2013-11-17 13:40 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2013-10-28 12:16 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, Geert Uytterhoeven
If SHARK_USE_LEDS=1, but CONFIG_PM=n:
drivers/media/radio/radio-shark.c:275: warning: ‘shark_resume_leds’ defined but not used
Instead of making the #ifdef logic even more complicated (there are already
two definitions of shark_resume_leds()), mark shark_resume_leds() inline to
kill the compiler warning. shark_resume_leds() is small and it has only one
caller.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
{cris,m68k,parisc,sparc,xtensa}-all{mod,yes}config
drivers/media/radio/radio-shark.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/radio/radio-shark.c b/drivers/media/radio/radio-shark.c
index b91477212413..050b3bb96fec 100644
--- a/drivers/media/radio/radio-shark.c
+++ b/drivers/media/radio/radio-shark.c
@@ -271,7 +271,7 @@ static void shark_unregister_leds(struct shark_device *shark)
cancel_work_sync(&shark->led_work);
}
-static void shark_resume_leds(struct shark_device *shark)
+static inline void shark_resume_leds(struct shark_device *shark)
{
if (test_bit(BLUE_IS_PULSE, &shark->brightness_new))
set_bit(BLUE_PULSE_LED, &shark->brightness_new);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] radio-shark: Mark shark_resume_leds() inline to kill compiler warning
2013-10-28 12:16 [PATCH] [media] radio-shark: Mark shark_resume_leds() inline to kill compiler warning Geert Uytterhoeven
@ 2013-11-17 13:40 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2013-11-17 13:40 UTC (permalink / raw)
To: Geert Uytterhoeven, Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel
Hi,
On 10/28/2013 01:16 PM, Geert Uytterhoeven wrote:
> If SHARK_USE_LEDS=1, but CONFIG_PM=n:
>
> drivers/media/radio/radio-shark.c:275: warning: ‘shark_resume_leds’ defined but not used
>
> Instead of making the #ifdef logic even more complicated (there are already
> two definitions of shark_resume_leds()), mark shark_resume_leds() inline to
> kill the compiler warning. shark_resume_leds() is small and it has only one
> caller.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> {cris,m68k,parisc,sparc,xtensa}-all{mod,yes}config
>
> drivers/media/radio/radio-shark.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/radio/radio-shark.c b/drivers/media/radio/radio-shark.c
> index b91477212413..050b3bb96fec 100644
> --- a/drivers/media/radio/radio-shark.c
> +++ b/drivers/media/radio/radio-shark.c
> @@ -271,7 +271,7 @@ static void shark_unregister_leds(struct shark_device *shark)
> cancel_work_sync(&shark->led_work);
> }
>
> -static void shark_resume_leds(struct shark_device *shark)
> +static inline void shark_resume_leds(struct shark_device *shark)
> {
> if (test_bit(BLUE_IS_PULSE, &shark->brightness_new))
> set_bit(BLUE_PULSE_LED, &shark->brightness_new);
>
Thanks for the patch. I've added this to my tree for 3.13 .
Regards,
Hans
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-17 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-28 12:16 [PATCH] [media] radio-shark: Mark shark_resume_leds() inline to kill compiler warning Geert Uytterhoeven
2013-11-17 13:40 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).