From: Paul Bolle <pebolle@tiscali.nl>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Martin Walch <walch.martin@web.de>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [kconfig] update: results of some syntactical checks
Date: Sat, 02 Nov 2013 20:55:09 +0100 [thread overview]
Message-ID: <1383422109.4378.15.camel@x220.thuisdomein> (raw)
In-Reply-To: <20131102174047.70c24ed8@samsung.com>
On Sat, 2013-11-02 at 17:40 -0200, Mauro Carvalho Chehab wrote:
> Em Sat, 02 Nov 2013 20:20:54 +0100
> Paul Bolle <pebolle@tiscali.nl> escreveu:
> > Those are obvious typos. Still present in v3.12-rc7. Perhaps you'd like
> > to send the trivial patch to fix this?
>
> Yes, it is a typo...
>
> > > Probably, it was meant to say something like
> > > > depends on SMS_USB_DRV = SMS_SDIO_DRV
>
> But this is not the right thing to do. The Kconfig logic here is that it
> should depends on !SMS_SDIO_DRV or SMS_USB_DRV = SMS_SDIO_DRV.
For the record: my reason for suggesting to Martin to send patches is
that sending a (trivial) patch often turns out to be a quick way to get
issues like that resolved. Maintainers seem to react quite quickly on
patches. Perhaps even faster if a patch is not solving the issue at hand
entirely correct! Messages like Martin's, that basically state that
there are one or more tree-wide problems, seem to be overlooked easily.
> I remember I made a patch like that while testing some things with this
> driver, but it seems that I forgot to push. I might have it somewhere on
> my test machine.
Paul Bolle
next prev parent reply other threads:[~2013-11-02 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 22:03 [kconfig] update: results of some syntactical checks Martin Walch
2013-11-02 19:20 ` Paul Bolle
2013-11-02 19:40 ` Mauro Carvalho Chehab
2013-11-02 19:55 ` Paul Bolle [this message]
2014-02-11 12:45 ` Paul Bolle
2014-04-16 15:47 ` [PATCH] [media] sms: Remove CONFIG_ prefix from Kconfig symbols Paul Bolle
2014-06-16 12:38 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383422109.4378.15.camel@x220.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=walch.martin@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox