public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [media] si4713: Remove "select SI4713"
Date: Sun, 09 Feb 2014 15:56:17 +0100	[thread overview]
Message-ID: <1391957777.25424.15.camel@x220> (raw)

Commits 7391232e1215 ("[media] si4713: Reorganized drivers/media/radio
directory") and b874b39fcd2f ("[media] si4713: Added the USB driver for
Si4713") both added a "select SI4713". But there's no Kconfig symbol
SI4713, so these selects are nops. It's not clear why they were added
but it's safe to remove them anyway.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Untested!

 drivers/media/radio/si4713/Kconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/media/radio/si4713/Kconfig b/drivers/media/radio/si4713/Kconfig
index a7c3ba8..ed51ed0 100644
--- a/drivers/media/radio/si4713/Kconfig
+++ b/drivers/media/radio/si4713/Kconfig
@@ -1,7 +1,6 @@
 config USB_SI4713
 	tristate "Silicon Labs Si4713 FM Radio Transmitter support with USB"
 	depends on USB && RADIO_SI4713
-	select SI4713
 	---help---
 	  This is a driver for USB devices with the Silicon Labs SI4713
 	  chip. Currently these devices are known to work.
@@ -16,7 +15,6 @@ config USB_SI4713
 config PLATFORM_SI4713
 	tristate "Silicon Labs Si4713 FM Radio Transmitter support with I2C"
 	depends on I2C && RADIO_SI4713
-	select SI4713
 	---help---
 	  This is a driver for I2C devices with the Silicon Labs SI4713
 	  chip.
-- 
1.8.5.3




             reply	other threads:[~2014-02-09 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-09 14:56 Paul Bolle [this message]
2014-02-09 15:18 ` [PATCH] [media] si4713: Remove "select SI4713" Hans Verkuil
2014-02-09 15:27   ` Paul Bolle
2014-02-09 17:04     ` Hans Verkuil
2014-02-09 17:37       ` Paul Bolle
2014-02-09 17:45         ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391957777.25424.15.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox