public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Devin Heitmueller <dheitmueller@kernellabs.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [media] drx-j: use customise option correctly
Date: Sat, 05 Apr 2014 13:20:02 +0200	[thread overview]
Message-ID: <1396696802.27142.15.camel@x220> (raw)
In-Reply-To: <20140403131143.69f324c7@samsung.com>

On Thu, 2014-04-03 at 13:11 -0300, Mauro Carvalho Chehab wrote:
> Devin Heitmueller (3):
>       [...]
>       [media] drx-j: add a driver for Trident drx-j frontend

This commit introduced a reference to DVB_FE_CUSTOMISE. But that Kconfig
symbol was removed in v3.7. It seems that the intent was to use
MEDIA_SUBDRV_AUTOSELECT here.

So the following (untested!) patch makes the Kconfig entry for "Micronas
DRX-J demodulator" use the current symbol. It is basically a copy of
d65fcbb0007b "([media] ts2020: use customise option correctly").
--------- >8 ---------
From: Paul Bolle <pebolle@tiscali.nl>

The Kconfig entry for "Micronas DRX-J demodulator" defaults to modular
if DVB_FE_CUSTOMISE is set. But that Kconfig symbol was replaced with
MEDIA_SUBDRV_AUTOSELECT as of v3.7. So use the new symbol. And negate
the logic, because MEDIA_SUBDRV_AUTOSELECT's logic is the opposite of
the former logic.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
 drivers/media/dvb-frontends/drx39xyj/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/drx39xyj/Kconfig b/drivers/media/dvb-frontends/drx39xyj/Kconfig
index 15628eb5cf0c..6c2ccb6a506b 100644
--- a/drivers/media/dvb-frontends/drx39xyj/Kconfig
+++ b/drivers/media/dvb-frontends/drx39xyj/Kconfig
@@ -1,7 +1,7 @@
 config DVB_DRX39XYJ
 	tristate "Micronas DRX-J demodulator"
 	depends on DVB_CORE && I2C
-	default m if DVB_FE_CUSTOMISE
+	default m if !MEDIA_SUBDRV_AUTOSELECT
 	help
 	  An ATSC 8VSB and QAM64/256 tuner module. Say Y when you want
 	  to support this frontend.
-- 
1.9.0


      parent reply	other threads:[~2014-04-05 11:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 16:11 [GIT PULL for v3.15-rc1] media updates Mauro Carvalho Chehab
2014-04-03 21:46 ` David Härdeman
2014-04-03 22:06   ` Mauro Carvalho Chehab
2014-04-04 17:26 ` Linus Torvalds
2014-04-04 19:17   ` Laurent Pinchart
2014-04-06  9:23     ` Philipp Zabel
2014-04-04 22:04 ` Linus Torvalds
2014-04-06 14:43   ` Mauro Carvalho Chehab
2014-04-05 11:20 ` Paul Bolle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396696802.27142.15.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=dheitmueller@kernellabs.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox