From: Joe Perches <joe@perches.com>
To: "Salva Peiró" <speiro@ai2.upv.es>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH] media-device: Remove duplicated memset() in media_enum_entities()
Date: Sat, 07 Jun 2014 08:55:24 -0700 [thread overview]
Message-ID: <1402156524.28369.4.camel@joe-AO725> (raw)
In-Reply-To: <1402152104-16865-1-git-send-email-speiro@ai2.upv.es>
On Sat, 2014-06-07 at 16:41 +0200, Salva Peiró wrote:
> After the zeroing the whole struct struct media_entity_desc u_ent,
> it is no longer necessary to memset(0) its u_ent.name field.
trivia:
> diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c
[]
> @@ -106,8 +106,6 @@ static long media_device_enum_entities(struct media_device *mdev,
> if (ent->name) {
> strncpy(u_ent.name, ent->name, sizeof(u_ent.name));
> u_ent.name[sizeof(u_ent.name) - 1] = '\0';
this could be strlcpy too.
next prev parent reply other threads:[~2014-06-07 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 14:41 [PATCH] media-device: Remove duplicated memset() in media_enum_entities() Salva Peiró
2014-06-07 15:55 ` Joe Perches [this message]
2014-07-17 11:51 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402156524.28369.4.camel@joe-AO725 \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=speiro@ai2.upv.es \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox